MIME-Version: 1.0
In-Reply-To: <871unlm79r.fsf@gmail.com>
References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>
	<1334752753-23970-2-git-send-email-felipe.contreras@gmail.com>
	<873981chpj.fsf@nikula.org>
	<CAMP44s2Ukz=kDaPHYG+jzR3pDfZGP+6Ojqc4Xz5J8PxEd9fKcQ@mail.gmail.com>
	<874nshm9yo.fsf@gmail.com>
	<CAMP44s0qHWGAiGWbKqa3pTJWbpvshoNpoc6EezJmDjE8xQ3ZYA@mail.gmail.com>
	<871unlm79r.fsf@gmail.com>
Date: Wed, 18 Apr 2012 18:45:04 +0300
Message-ID:
 <CAMP44s2bvMFPYBtR9FjKAV3ZG1rOJdjkWhPexgC7o_SF_ALC0Q@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] Add 'compose' command
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

On Wed, Apr 18, 2012 at 5:41 PM, Dmitry Kurochkin
<dmitry.kurochkin@gmail.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> On Wed, Apr 18, 2012 at 4:43 PM, Dmitry Kurochkin
>> <dmitry.kurochkin@gmail.com> wrote:
>>> Hi Felipe.
>>>
>>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>>
>>>> On Wed, Apr 18, 2012 at 4:06 PM, Jani Nikula <jani@nikula.org> wrote:
>>>>
>>>>> Running "notmuch compose" more than once within a second would result=
 in
>>>>> identical message ids for the messages, which is not a good idea. Tha=
t's
>>>>> not likely in interactive use, but the notmuch cli is highly scriptab=
le,
>>>>> so someone is bound to hit this.
>>>>>
>>>>> Some paranoid might also be worried about "leaking" the time you run
>>>>> "notmuch compose"... which may be different from the actual time you
>>>>> send the message.
>>>>
>>>> It's still better than the current situation; nothing. In any case,
>>>> people that have not needed this would not be affected; their UI would
>>>> override the Message-ID.
>>>>
>>>
>>> I disagree. =C2=A0If notmuch CLI generates a Message-ID, it must be a g=
ood
>>> one. =C2=A0Otherwise we make users falsely believe that they do have a =
proper
>>> Message-ID while in fact they do not. =C2=A0And that would bite them so=
oner
>>> or later.
>>
>> And then they'll report it, and we would fix it.
>>
>> Anyway, everything comes from a patch, so, do you have a patch,
>> pseudo-code, or even a suggestion?
>>
>
> A patch needs some positive reviews to be accepted. =C2=A0Replying to
> comments with "make a better patch" may not be the best strategy for
> getting your patches accepted.

I did not say "make a better patch" or anything of the sort. You made
comments, I replied to those comments.

Your argument is essentially:

a) we don't have feature X
b) this patch applies feature X imperfectly
c) I don't know how to implement X perfectly

I don't think "patch is not perfect" is a valid argument. No patch is
perfect, if you want a better patch, then *at least* you should
suggest what would make it better.

Cheers.

--=20
Felipe Contreras