From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp'
In-Reply-To: <1372030999-1262-1-git-send-email-amdragon@mit.edu>
References: <1372030999-1262-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.15.2+171~ge2f30a2 (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Mon, 24 Jun 2013 20:00:27 +0100
Message-ID: <87zjuftjuc.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


This series looks good to me +1. 

Is it worth removing all the json (3 files with (require 'json) and the
async json parser) too?

Best wishes

Mark

On Mon, 24 Jun 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> This is just like `notmuch-call-notmuch-json', but parses S-expression
> output.  Note that, also like `notmuch-call-notmuch-json', this
> doesn't consider trailing data to be an error, which may or may not be
> what we want in the long run.
> ---
>  emacs/notmuch-lib.el |   17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 534f217..36eacc1 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -484,6 +484,23 @@ an error."
>  	      (json-read)))
>  	(delete-file err-file)))))
>  
> +(defun notmuch-call-notmuch-sexp (&rest args)
> +  "Invoke `notmuch-command' with ARGS and return the parsed S-exp output.
> +
> +If notmuch exits with a non-zero status, this will pop up a
> +buffer containing notmuch's output and signal an error."
> +
> +  (with-temp-buffer
> +    (let ((err-file (make-temp-file "nmerr")))
> +      (unwind-protect
> +	  (let ((status (apply #'call-process
> +			       notmuch-command nil (list t err-file) nil args)))
> +	    (notmuch-check-exit-status status (cons notmuch-command args)
> +				       (buffer-string) err-file)
> +	    (goto-char (point-min))
> +	    (read (current-buffer)))
> +	(delete-file err-file)))))
> +
>  (defun notmuch-start-notmuch (name buffer sentinel &rest args)
>    "Start and return an asynchronous notmuch command.
>  
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch