Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7FD33431FD0 for ; Mon, 26 Dec 2011 02:46:24 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wzZDnWSqyePs for ; Mon, 26 Dec 2011 02:46:24 -0800 (PST) Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B0405431FB6 for ; Mon, 26 Dec 2011 02:46:23 -0800 (PST) Received: by wgbds13 with SMTP id ds13so16369738wgb.2 for ; Mon, 26 Dec 2011 02:46:21 -0800 (PST) Received: by 10.227.203.131 with SMTP id fi3mr29291992wbb.17.1324896381070; Mon, 26 Dec 2011 02:46:21 -0800 (PST) Received: from hotblack-desiato.hh.sledj.net (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) by mx.google.com with ESMTPS id q34sm9997751wbm.15.2011.12.26.02.46.18 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 26 Dec 2011 02:46:19 -0800 (PST) Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) id 3E869A0765; Mon, 26 Dec 2011 10:46:17 +0000 (GMT) To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode. In-Reply-To: <87ipl7kt82.fsf@gmail.com> References: <1324665712-2419-1-git-send-email-dme@dme.org> <87ipl7kt82.fsf@gmail.com> User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org) Emacs/24.0.92.1 (x86_64-pc-linux-gnu) From: David Edmondson Date: Mon, 26 Dec 2011 10:46:13 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2011 10:46:24 -0000 --=-=-= Content-Type: text/plain On Fri, 23 Dec 2011 23:01:33 +0400, Dmitry Kurochkin wrote: > * Revert changes to notmuch-show-advance-and-archive. Why? (I mean, because the change is poor or just that it's unrelated or because I didn't mention it) > * Can we split this in two patches? One for rewind and another for > advance. I'll think about that. Is there a specific reason? I'm not particularly in favour of splitting things just for the sake of it. > * Does this patch change the behavior of the functions or is it just > meant to simplify the code? If it is the former, it would be really > nice to have tests for it. I believe that it changes the behaviour. I'll write tests. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk74UHUACgkQaezQq/BJZRa0pgCcD6LQ2Zth6yMgRrU2BIH5UHxd baMAnRJRnY4ed7cPIytABscoq6UlF98W =3mOj -----END PGP SIGNATURE----- --=-=-=--