From: Carl Worth <cworth@cworth.org>
To: James Westby <jw+debian@jameswestby.net>, notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH] Store thread ids for messages that we haven't
	seen yet
In-Reply-To: <1268515677-12692-1-git-send-email-jw+debian@jameswestby.net>
References: <87fx72o8pq.fsf@yoom.home.cworth.org>
	<1268515677-12692-1-git-send-email-jw+debian@jameswestby.net>
Date: Tue, 13 Apr 2010 08:20:48 -0700
Message-ID: <87sk6ze5v3.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Sat, 13 Mar 2010 16:27:57 -0500, James Westby <jw+debian@jameswestby.net> wrote:
> This allows us to thread messages even when we receive them out of
> order, or never receive the root.

Thanks for this patch, James! It's especially nice to have the fix come
in with additions to the test suite as well.

I did split up the commit so the addition to the test suite happens
first. That way it's easy to test the test itself, (verifying that it
fails before the fix, and then passes after the fix).

I also added a few documentation and other cleanups as follow-on
commits. Hopefully, they don't change the logic at all, but make things
easier to understand.

So that's all pushed.

Then, I started implementing support for retroactively storing
thread_ids for non-existing messages references in already-existing
messages. It took me perhaps too long that a change like that, (while
useful), is too invasive for the current 0.2 release, and not essential
for this particular feature.

So I've postponed that part at least. I hope to make a database-schema
upgrade a key part of a release in a couple of cycles, (for this
feature and for "list:" and "folder:").

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxIvQ6JDdNq8qSWgRAnmSAKComNhIxOwsa5p7ZlYHM3fkOqUwNwCfULQ5
LCLkyzJ2CVkwpEsNSJvkJTw=
=mSrd
-----END PGP SIGNATURE-----
--=-=-=--