From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/8] hex-escape: be more strict about the format while
	decoding
In-Reply-To: <87fwcitnuk.fsf@zancas.localnet>
References: <cover.1333231401.git.jani@nikula.org>
	<81e543344ffe8e2761afd57a2268e8b362f4aef4.1333231401.git.jani@nikula.org>User-Agent:	Notmuch/0.12+70~g46e73fe (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu) <87fwcitnuk.fsf@zancas.localnet>
User-Agent: Notmuch/0.11.1+222~ga47a98c (http://notmuchmail.org) Emacs/23.1.1
	(i686-pc-linux-gnu)
Date: Thu, 05 Apr 2012 11:49:42 +0000
Message-ID: <87hawyxusp.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 05 Apr 2012 08:33:23 -0300, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
> 
> > Signed-off-by: Jani Nikula <jani@nikula.org>
> >
> > ---
> >
> > This could be folded to "hex-escape: (en|de)code strings to/from
> > restricted character set".
> 
> That's probably a good plan.
> 
> > -	    if (len < 3)
> > +	    if (!isxdigit ((unsigned char) p[1]) ||
> > +		!isxdigit ((unsigned char) p[2]))
> 
> What happens if there are not two characters after the escape? Is this
> relying on calling isxdigit on the null terminator?

It is, and technically there's nothing wrong with that. Would you prefer
explicit checks for '\0' in the if condition, for clarity? Or a comment
about it?

Jani.