Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id A88856DE17EB
 for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 05:09:07 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.117
X-Spam-Level: 
X-Spam-Status: No, score=0.117 tagged_above=-999 required=5 tests=[AWL=0.117]
 autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id 4opA9Gt6M83l for <notmuch@notmuchmail.org>;
 Sun, 30 Aug 2015 05:09:05 -0700 (PDT)
Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
 by arlo.cworth.org (Postfix) with ESMTPS id B08B36DE1642
 for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 05:09:05 -0700 (PDT)
Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
 (envelope-from <david@tethera.net>)
 id 1ZW1OI-0007H6-Ak; Sun, 30 Aug 2015 12:07:18 +0000
Received: (nullmailer pid 22233 invoked by uid 1000); Sun, 30 Aug 2015
 12:06:57 -0000
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case
 insensitive address
In-Reply-To:
 <b33abd9a0117628932b3f197f536cf1a58793779.1440859765.git.jani@nikula.org>
References: <cover.1440859765.git.jani@nikula.org>
 <b33abd9a0117628932b3f197f536cf1a58793779.1440859765.git.jani@nikula.org>
User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Sun, 30 Aug 2015 09:06:57 -0300
Message-ID: <874mjht1y6.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Aug 2015 12:09:07 -0000

Jani Nikula <jani@nikula.org> writes:

> Consider all variants of an email address as one, and print the most
> common variant.

Other than the quibbles already mentioned, the series looks ok to
me. For production it should have one or two tests I guess. Oh, and man
page updates. But you knew that I guess.

I can live with the current argument syntax, but since a certain a mount
of bikeshedding is expected, here is an alternative suggestion

--deduplication={none|mailbox|address}