Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 134EE431FBF for ; Thu, 8 May 2014 05:31:46 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NmZP1k8xP6Eg for ; Thu, 8 May 2014 05:31:17 -0700 (PDT) Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 72D76431FAE for ; Thu, 8 May 2014 05:31:17 -0700 (PDT) Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim 4.72) (envelope-from ) id 1WiNSa-00077a-7x; Thu, 08 May 2014 12:30:00 +0000 Received: (nullmailer pid 27207 invoked by uid 1000); Thu, 08 May 2014 12:29:30 -0000 From: David Bremner To: Charles Celerier , notmuch@notmuchmail.org Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore. In-Reply-To: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu> References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu> User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Thu, 08 May 2014 21:29:30 +0900 Message-ID: <87iopgv4gl.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2014 12:31:46 -0000 Charles Celerier writes: > An underscore should precede every function name in > lib/notmuch-private.h. Is this a reference to notmuch coding style document, or something else? > This was not true and was noted by the failure of test > T360-symbol-hiding on Mac OS/X. This patch inserts an underscore > before each function name in lib/notmuch-private.h where the > underscore was missing and renames functions appropriately where they > are used. I'm not sure I understand the problem this patch is intended to solve. Is the problem that symbols are being inadvertantly exported? Or the test is wrong? d