Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 295E9429E20 for ; Mon, 9 May 2011 05:57:10 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LSJGcOBAvcnS for ; Mon, 9 May 2011 05:57:08 -0700 (PDT) Received: from mail-pv0-f181.google.com (mail-pv0-f181.google.com [74.125.83.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 925AA431FB5 for ; Mon, 9 May 2011 05:57:08 -0700 (PDT) Received: by pvg13 with SMTP id 13so2801392pvg.26 for ; Mon, 09 May 2011 05:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=/96TTCtKUG5LnihV6RLIsMsHfL9j+ZrFBiF+G7N36y4=; b=wEdNvZ9BWnuQqjKAA4S1PO4nWhusxYoocIdhCD51OUFd8xQL5X5DHDr7sbfvjZbPbj mseNrH+duxPOtVh+N+blMyGiglESfLmdazvqaMjjoTXHPC/l1OvLHdsQMAh7Ca384c+M rjddMAl4ZEZ2A6yroNOCwRYp6rE3NWlmossYE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=uWiKMkT4vSyDD3VXb+eE3nW6x0gDooSyL0Db1OvT90EuYyUBRSNvAMvJZ1xWXNl4tZ tsy7SQNKlWpmagWjoBz+p6xs603ydRO79vIRC9PQp4r3mbwD+rgtKD9zzmAavGw7GxmT 8D9owydY5O/rws0HWFZwfQXF3gQ+Ad3mh0oo0= MIME-Version: 1.0 Received: by 10.68.56.8 with SMTP id w8mr9527072pbp.334.1304945827435; Mon, 09 May 2011 05:57:07 -0700 (PDT) Received: by 10.68.51.198 with HTTP; Mon, 9 May 2011 05:57:07 -0700 (PDT) In-Reply-To: <87bozcvzdy.fsf@zancas.localnet> References: <1304924794-20380-1-git-send-email-anton@khirnov.net> <87bozcvzdy.fsf@zancas.localnet> Date: Mon, 9 May 2011 08:57:07 -0400 Message-ID: Subject: Re: [PATCH] python/thread: always return a string in get_subject/authors From: servilio To: David Bremner Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2011 12:57:10 -0000 On 9 May 2011 08:20, David Bremner wrote: > On Mon, =C2=A09 May 2011 09:06:34 +0200, Anton Khirnov wrote: >> Now None is returned when those don't exist, which is inconvenient to >> deal with. > > I'm not using the python bindings, but from a philosophical point of > view, this change makes me a bit uncomfortable since it apparently > merges two cases together, and makes an error (no Subject) > indistinguishable from an odd situation (Subject of empty string). > Or am I missing something here? I see the the same issue. Servilio