From: Mark Walters <markwalters1009@gmail.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [Patch v2 0/4] Control selection of From: header when replying
In-Reply-To: <87ipjlix6r.fsf@gmail.com>
References: <1328388317-20161-1-git-send-email-markwalters1009@gmail.com>
	<87ipjlix6r.fsf@gmail.com>
User-Agent: Notmuch/0.11+154~ged6d37e (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Sun, 05 Feb 2012 12:50:49 +0000
Message-ID: <87y5shv3yu.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Mark.
> 
> I am not sure I like this solution.  My concerns are:
> 
> * New option looks too complex, too specific.
> 
> * There are more aspects of notmuch reply behavior which users would
>   like to change (e.g. which part to quote).  If we add an option for
>   each, we complicate both nomtuch show UI and code.
> 
> The problem is that notmuch show output format is too limiting.  Instead
> of providing myriad of options for tweaking notmuch show text format
> behavior, we should add JSON format for notmuch reply similar to nomtuch
> show.  That would allow notmuch reply to produce structured output with
> required additional information, which should be enough for users to
> construct whatever reply they want.
> 
> In this particular case, notmuch reply JSON format could have
> "from-source" attribute that would indicate how it was guessed.
> 
> Now the best part.  Not so long ago, Adam (in Cc) provided a patch for
> improving nomtuch reply for HTML-only emails.  At first he added an
> option for notmuch reply, like you did for from-guessing.  I suggested
> him to implement it based on the JSON format instead and he did.  AFAIK
> the latest version of his patches is [1].  I did not look at the code
> though.  It seems that it is waiting for more review.
> 
> So, instead of adding more nomtuch show options, I think a better
> solution is to work with Adam to get the notmuch reply JSON format to
> master and then fix the from-guessing issue by adding an attribute to
> notmuch reply JSON format.

Yes I think you are quite right: this would be a better solution
(particularly as Adam has already done all the hard work!)

Many thanks

Mark