Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 88C574196F0 for ; Tue, 27 Apr 2010 09:34:00 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -4.2 X-Spam-Level: X-Spam-Status: No, score=-4.2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qp3aayTHRDTT for ; Tue, 27 Apr 2010 09:34:00 -0700 (PDT) Received: from ipex3.johnshopkins.edu (ipex3.johnshopkins.edu [128.220.161.140]) by olra.theworths.org (Postfix) with ESMTP id D801B431FC1 for ; Tue, 27 Apr 2010 09:33:59 -0700 (PDT) X-IronPort-AV: E=Sophos;i="4.52,280,1270440000"; d="scan'208";a="380295455" Received: from c-69-255-36-229.hsd1.md.comcast.net (HELO lucky) ([69.255.36.229]) by ipex3.johnshopkins.edu with ESMTP/TLS/AES256-SHA; 27 Apr 2010 12:33:58 -0400 Received: from jkr by lucky with local (Exim 4.69) (envelope-from ) id 1O6njR-0002Rq-3p; Tue, 27 Apr 2010 12:33:57 -0400 From: Jesse Rosenthal To: Notmuch developer list Subject: [PATCH] emacs: Remove conditional from notmuch-fcc-initialization. User-Agent: Notmuch/0.3 (http://notmuchmail.org) Emacs/23.1.1 (i486-pc-linux-gnu) Date: Tue, 27 Apr 2010 12:33:57 -0400 Message-ID: <87k4rskg7e.fsf@jhu.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2010 16:34:00 -0000 The fcc code would only initialize if notmuch-fcc-dirs was set. This was a problem if you reset the variable, or added the variable later during initialization. Now we always add the fcc hook, but it doesn't do anything unless notmuch-fcc-dirs are set. --- emacs/notmuch-maildir-fcc.el | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el index 8af6f00..d9a8f9b 100644 --- a/emacs/notmuch-maildir-fcc.el +++ b/emacs/notmuch-maildir-fcc.el @@ -47,7 +47,6 @@ (defun notmuch-fcc-initialization () "If notmuch-fcc-directories is set, hook them into the message-fcc-handler-function" -(if (not (eq notmuch-fcc-dirs nil)) (progn ;Set up the message-fcc-handler to move mails to the maildir in Fcc ;The parameter is hardcoded to mark messages as "seen" (setq message-fcc-handler-function @@ -57,7 +56,7 @@ ;(preferrably we would use message-header-setup-up, but notmuch-reply ; munges headers after that is run, so it won't work for replies within ; notmuch) - (add-hook 'message-send-hook 'notmuch-fcc-header-setup)))) + (add-hook 'message-send-hook 'notmuch-fcc-header-setup)) (defun notmuch-fcc-header-setup () "Can be added to message-send-hook and will set the FCC header -- 1.6.3.3