Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AF50A431FAF for ; Sun, 15 Sep 2013 01:29:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D7xCySRSMzgD for ; Sun, 15 Sep 2013 01:29:02 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 609BB431FAE for ; Sun, 15 Sep 2013 01:29:02 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id A77791000B2; Sun, 15 Sep 2013 11:28:57 +0300 (EEST) From: Tomi Ollila To: Gregor Zattler , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: distinguish tag `flagged' on terminal In-Reply-To: <20130904170655.GA13154@boo.workgroup> References: <20130904170655.GA13154@boo.workgroup> User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Sep 2013 08:29:06 -0000 On Wed, Sep 04 2013, Gregor Zattler wrote: > Change foreground color to `blue' like lines representing threads > with flagged messages in notmuch-search. Before tag `flagged' was > shown in notmuch-show buffers as image star on graphical frames while > there was no visible distinction to other flags on terminal frames. > --- This patch Looks Good =E2=84=A2 and works fine. > With this patch applied tag `unread' is now shown with foreground > `red' while tag `flagged' is shown in `blue'. IMHO this should be > the other way around as flagged messages should be flagged more > prominently than mere unread ones.=20=20 Probably so. I just (normally (*)) have 0 email with tag 'flagged' and many with 'unread'. I've tried to go away re-tagging messages w/ unread but... Anyway now I have 'flagged' with blue and other tags (sans unread) with dark blue foreground ;D (*) added 'flagged' tag to this message to test this feature. > Sorry, did not find git-send-mail on my debian jessie box!? Well, you managed to make perfectly good email out of it... (without risks realized, that is :) Tomi > emacs/notmuch-tag.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el > index 064cfa8..5c50ade 100644 > --- a/emacs/notmuch-tag.el > +++ b/emacs/notmuch-tag.el > @@ -30,7 +30,8 @@ >=20=20 > (defcustom notmuch-tag-formats > '(("unread" (propertize tag 'face '(:foreground "red"))) > - ("flagged" (notmuch-tag-format-image-data tag (notmuch-tag-star-icon= )))) > + ("flagged" (propertize tag 'face '(:foreground "blue")) > + (notmuch-tag-format-image-data tag (notmuch-tag-star-icon)))) > "Custom formats for individual tags. >=20=20 > This gives a list that maps from tag names to lists of formatting > --=20 > 1.8.4.rc3 > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch