Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id CC5766DE1641 for ; Sat, 7 Nov 2015 03:04:45 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.133 X-Spam-Level: X-Spam-Status: No, score=-0.133 tagged_above=-999 required=5 tests=[AWL=0.437, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HIU3WSe7P-Bw for ; Sat, 7 Nov 2015 03:04:44 -0800 (PST) Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by arlo.cworth.org (Postfix) with ESMTPS id A62B16DE1502 for ; Sat, 7 Nov 2015 03:04:43 -0800 (PST) Received: by wicll6 with SMTP id ll6so44094752wic.0 for ; Sat, 07 Nov 2015 03:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=v08JaS5pM1YcDRXdHdewCd0pjNfHAWTnL1FC5b3KrdA=; b=DgEJXhz0oCzX6QuJZOPsSN1HTew1R7iZoMW8BPro9+Ri2m6+Q+mOSdzFhqLLXk/nwz 5Xwn2E7ryHamUYGl6ulBrU5afjJIkDuOi1B4kayiC+z8rYdL2jmnWPU2nBcVNMGyTAsc n2w8DGfoIjUeF6hA8ivCuUrUR3n5wPrIXeIhqKBCOAoINcTjsKZVI7SSOxuwg7Cu+ynY uLs4QtAoFO3N22Dk6OjTNvisOglo8CUDQesa+9GpefBLgI56tJc05WO8YVnhkUwy0dx6 TSQkFXOJzIp8aCIUHHceLdpODiU7zU94N584ufEL6RYNHHtpWhZ9OODIubYQWzgX74CM DWIw== X-Received: by 10.194.122.230 with SMTP id lv6mr22469680wjb.2.1446894281519; Sat, 07 Nov 2015 03:04:41 -0800 (PST) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id r12sm3424901wmd.17.2015.11.07.03.04.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2015 03:04:40 -0800 (PST) From: Mark Walters To: notmuch@notmuchmail.org Subject: [PATCH v4 0/7] emacs: Improve the cited message included in replies Date: Sat, 7 Nov 2015 11:04:29 +0000 Message-Id: <1446894276-7814-1-git-send-email-markwalters1009@gmail.com> X-Mailer: git-send-email 2.1.4 X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 11:04:45 -0000 This is a rebase and somewhat tweaked version of dme's series from last year id:1399897769-26809-1-git-send-email-dme@dme.org One particular motivation for this series is that it fixes a long standing bug we have that replying to a message with an rfc822 part completely omits that part. It also fixes the bug whereby we don't include application/octet-stream parts which are actually text/plain (and thus are displayed in show mode). This series makes the reply code use the same code as the show code so everything works as expected: the reply buffer looks essentially the same as the show buffer. There is one slight difference: the user might want different part headers displayed when replying; both because the audience is different (a non-notmuch using recipient) and because the buttons don't "work" (you can't click on them to show or view a part). Dme and I disagree on which of these we would like to see so make that customisable. The key change is patch 3 which switches how reply works. Also note that patch 2 is almost all whitespace change as the changes modify the indentation. Best wishes Mark David Edmondson (6): emacs/show: Re-arrange determination if a part header is necessary emacs/show: Accommodate the lack of part header buttons emacs/mua: Generate improved cited text for replies emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart' emacs/show: Make the insertion of part headers overridable. emacs/mua: Let user specify which parts get a header in citations. Mark Walters (1): test: fix the tests for the new reply code emacs/notmuch-mua.el | 60 ++++++++++----------- emacs/notmuch-show.el | 141 +++++++++++++++++++++++++++++++------------------- test/T310-emacs.sh | 32 ++++++++++++ test/test-lib.el | 4 ++ 4 files changed, 155 insertions(+), 82 deletions(-) -- 2.1.4