From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Mark Walters
	<markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el
In-Reply-To: <m2a9ejkb05.fsf@guru.guru-group.fi>
References: <87y5sipcjn.fsf@qmul.ac.uk>
	<1329900529-16295-1-git-send-email-markwalters1009@gmail.com>
	<87bnyzoqq9.fsf@zancas.localnet> <m2a9ejkb05.fsf@guru.guru-group.fi>
User-Agent: Notmuch/0.17+42~gb867564 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 25 Jan 2014 21:20:26 -0400
Message-ID: <87y523mtd1.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Tomi Ollila <tomi.ollila@iki.fi> writes:

>
> How about doing it with defadvice with something like:
>
> (from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice
> this happening with emacs 23.3 -- David can check whether 23.4 if
> affected)

It's fixed in 23.4

>
> (if (and (= emacs-major-version 23) (< emacs-minor-version 4))
>   (defadvice ido-completing-read (before notmuch-ido-mode-init activate)
>       (unless (ido-mode) (ido-mode t))
>       (ad-disable-advice 'ido-completing-read 'before 'notmuch-ido-mode-init)))

Advice always seems over complex to me, but maybe I'm just
prejudiced/ignorant.

Can you decode/reverse-engineer the fix in 

    http://permalink.gmane.org/gmane.emacs.bugs/41957

?

Maybe the advice or whatever should call 

   (ido-init-completion-maps)
   (add-hook 'minibuffer-setup-hook 'ido-minibuffer-setup)
   (add-hook 'choose-completion-string-functions
      'ido-choose-completion-string))

Although that looks worryingly permanent.



d