To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
	Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add completion to "tag all" operation ("*"
 binding)
In-Reply-To: <87wr8fqlpg.fsf@gmail.com>
References: <1327540351-5249-1-git-send-email-dmitry.kurochkin@gmail.com>
	<20120126013727.GB1176@mit.edu> <87wr8fqlpg.fsf@gmail.com>
User-Agent: Notmuch/0.11+114~g550724b (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Thu, 26 Jan 2012 08:46:00 +0000
Message-ID: <cunobtqlulz.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Thu, 26 Jan 2012 05:47:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> > > +  ;; Perform some validation
> > > +  (let ((words action))
> > > +    (when (null words) (error "No operation given"))
> > > +    (while words
> > > +      (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words))
> > > +	(error "Action must be of the form `+thistag -that_tag'"))
> > > +      (setq words (cdr words))))
> >=20
> > This should really be a mapc or a dolist, but maybe that's for another
> > patch.
>=20
> Yes, I changed "this_tag" spelling in v2, but would prefer to leave
> non-trivial changes in this code for another patch.

If you were going to submit another patch then fine, but the chances are
it will just get forgotten.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8hEsgACgkQaezQq/BJZRb7lQCcDunr5BSWhn05WUQ3DPccHNku
jd8An3OIzrujNMKdFXJmBqzsfeXaNfO1
=nxTf
-----END PGP SIGNATURE-----
--=-=-=--