Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 86C766DE17BA for ; Tue, 29 Dec 2015 02:05:16 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.685 X-Spam-Level: X-Spam-Status: No, score=0.685 tagged_above=-999 required=5 tests=[AWL=0.033, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EQ3vA9PiqKHK for ; Tue, 29 Dec 2015 02:05:13 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 121246DE17B5 for ; Tue, 29 Dec 2015 02:05:02 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 98DFD10008E; Tue, 29 Dec 2015 12:05:17 +0200 (EET) From: Tomi Ollila To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH v2] test: Unset ALTERNATE_EDITOR before running emacsclient In-Reply-To: <1451379137-14330-1-git-send-email-sojkam1@fel.cvut.cz> References: <1451379137-14330-1-git-send-email-sojkam1@fel.cvut.cz> User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2015 10:05:16 -0000 On Tue, Dec 29 2015, Michal Sojka wrote: > ALTERNATE_EDITOR causes emacsclient to run an alternate editor if the > emacs server is not ready. This can collide with intended > functionality in test-lib.sh. > > If the ALTERNATE_EDITOR is set but empty, emacsclient runs emacs > daemon and tries to connect to it. When this happens the emacs run by > test-lib.sh fails to start the server and the subsequent attempts to > use the server fail because the daemon started by emacsclient does not > know about notmuch-test-progn. This leads to test suite failure due to > time out on any emacs test. > --- LGTM. Tomi > test/test-lib.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 126911f..270c718 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -82,6 +82,9 @@ unset CDPATH > > unset GREP_OPTIONS > > +# For emacsclient > +unset ALTERNATE_EDITOR > + > # Convenience > # > # A regexp to match 5 and 40 hexdigits > -- > 2.6.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch