Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 6B0E46DE1638 for ; Fri, 10 Apr 2015 16:58:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.38 X-Spam-Level: X-Spam-Status: No, score=0.38 tagged_above=-999 required=5 tests=[AWL=0.380] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hknz1w0dZcZS for ; Fri, 10 Apr 2015 16:58:13 -0700 (PDT) Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net [87.98.215.224]) by arlo.cworth.org (Postfix) with ESMTPS id 80FF96DE15E7 for ; Fri, 10 Apr 2015 16:58:13 -0700 (PDT) Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim 4.80) (envelope-from ) id 1YginS-0006mq-Ve; Fri, 10 Apr 2015 23:57:14 +0000 Received: (nullmailer pid 21632 invoked by uid 1000); Fri, 10 Apr 2015 23:56:57 -0000 From: David Bremner To: Baptiste , notmuch@notmuchmail.org Subject: Re: [PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages In-Reply-To: <87fv9kq1fu.fsf@vm_arch_64.bat.fr.eu.org> References: <87ioegq5ca.fsf@vm_arch_64.bat.fr.eu.org> <87fv9kq1fu.fsf@vm_arch_64.bat.fr.eu.org> User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sat, 11 Apr 2015 08:56:56 +0900 Message-ID: <87pp7bwn93.fsf@maritornes.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Apr 2015 23:58:16 -0000 Baptiste writes: > Hi,=20 > >> What about another automatic tag to re-add to an existing mail when =3Dn= otmuch new=3D detect a moved, renamed or reflagged message=C2=A0... > > the following code sample seems to actually do the job=C2=A0=E2=80=A6 > Sorry I still haven't had a chance to review your patch in detail. A few things I did wonder about - There is a patch series in progress to add a "last modified time" to all messages [1]. It seems like this should also work for your case since renaming counts as modification in this context. It might not be quite as easy/efficient for your use case as your proposal, but it seems like it should work. - What about messages added by notmuch-insert? I guess you are maybe not using it, but it seems odd to only support changes detected in notmuch-new. - This might be because I haven't worked through the details, but it isn't obvious to me how your patch behaves with messages with multiple files on disk. [1]: id:1428274754-1698-1-git-send-email-david@tethera.net