From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, Austin Clements <amdragon@MIT.EDU>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add completion to "tag all" operation ("*"
 binding)
In-Reply-To: <cunobtqlulz.fsf@hotblack-desiato.hh.sledj.net>
References: <1327540351-5249-1-git-send-email-dmitry.kurochkin@gmail.com>
	<20120126013727.GB1176@mit.edu> <87wr8fqlpg.fsf@gmail.com>
	<cunobtqlulz.fsf@hotblack-desiato.hh.sledj.net>
User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 26 Jan 2012 21:39:22 +0400
Message-ID: <87vcny8it1.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Thu, 26 Jan 2012 08:46:00 +0000, David Edmondson <dme@dme.org> wrote:
> On Thu, 26 Jan 2012 05:47:07 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > > > +  ;; Perform some validation
> > > > +  (let ((words action))
> > > > +    (when (null words) (error "No operation given"))
> > > > +    (while words
> > > > +      (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words))
> > > > +	(error "Action must be of the form `+thistag -that_tag'"))
> > > > +      (setq words (cdr words))))
> > > 
> > > This should really be a mapc or a dolist, but maybe that's for another
> > > patch.
> > 
> > Yes, I changed "this_tag" spelling in v2, but would prefer to leave
> > non-trivial changes in this code for another patch.
> 
> If you were going to submit another patch then fine, but the chances are
> it will just get forgotten.

No worries, v5 has a cleanup patch added :)

Regards,
  Dmitry