DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=sender:from:to:cc:subject:in-reply-to:references:date:message-id
	:mime-version:content-type;
	b=hz+XV7zIoeYCe6gg5qyurYV08wltn/5bC4P7kFB+vFQsC8ZgR2hrAitjk/J5LLY6Qa
	AfiVBR9TjNu6hhEIA1WcD+DqVl3/XzlgJ9vbkWctQh6B6+z/kz/AXzFKTXRqf6oSqFAX
	3JpiQuDIaqOBuondHtRDTCaackiCXHO3ZI4Ec=
Sender: Jed Brown <five9a2@gmail.com>
From: Jed Brown <jed@59A2.org>
To: Carl Worth <cworth@cworth.org>, Tassilo Horn <tassilo@member.fsf.org>,
	Mikhail Gusarov <dottedmag@dottedmag.net>
In-Reply-To: <87ljhtq98x.fsf@yoom.home.cworth.org>
References: <87ws1hldmu.fsf@thinkpad.tsdh.de>
	<87einpl50j.fsf@thinkpad.tsdh.de> <87ljhxjq5i.fsf@vertex.dottedmag>
	<876391l2si.fsf@thinkpad.tsdh.de> <87vdh1472z.fsf@59A2.org>
	<871vjlrv8b.fsf@yoom.home.cworth.org> <873a41dtbu.fsf@59A2.org>
	<87ljhtq98x.fsf@yoom.home.cworth.org>
Date: Thu, 26 Nov 2009 22:22:24 +0100
Message-ID: <87zl69c773.fsf@59A2.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: notmuch@notmuchmail.org
Subject: Re: [notmuch] Notmuch doesn't index new mails when mail location
 contains symlinks
Precedence: list

On Thu, 26 Nov 2009 13:14:22 -0800, Carl Worth <cworth@cworth.org> wrote:

> Then I'm still being really dense here. The non-propagation of mtime is
> the with actual directories. And the code is trying to do the right
> thing for that.

The stat() is correct, it's the check for the d_type field coming out of scandir().

20:08 [   jedbrown  ] cworth: I think there are two problems with symlinks.
20:08 [   jedbrown  ] cworth: First, notmuch-new.c:152 checks path_mtime which is mtime for the current directory.
20:09 [   jedbrown  ] cworth: Additionally, won't entry->d_type == DT_LNK for a symlink?
20:14 [     aneesh  ] jedbrown,  i already have a patch posted for that
20:15 [     aneesh  ] 1259125104-18785-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com


Jed