Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6DB27429E54 for ; Mon, 23 Jan 2012 13:36:40 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L2h1ukDrVJ7K for ; Mon, 23 Jan 2012 13:36:40 -0800 (PST) Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) by olra.theworths.org (Postfix) with ESMTP id DD06D429E21 for ; Mon, 23 Jan 2012 13:36:39 -0800 (PST) Received: by guru.guru-group.fi (Postfix, from userid 501) id 976D768056; Mon, 23 Jan 2012 23:36:38 +0200 (EET) From: Tomi Ollila To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/3] mime node: Record depth-first part numbers In-Reply-To: <1327285873-4713-2-git-send-email-amdragon@mit.edu> References: <1326918507-28033-1-git-send-email-amdragon@mit.edu> <1327285873-4713-1-git-send-email-amdragon@mit.edu> <1327285873-4713-2-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.11+99~g0528eb4 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 21:36:40 -0000 On Sun, 22 Jan 2012 21:31:11 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility with what we currently do. > --- LGTM. I did not understand the logic so after a while I concentrated on code robustness (i.e. this doesn't break anything). Future work depends on this. Tomi