Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1FCF0431FBC for ; Fri, 25 Dec 2009 12:09:22 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vV0DYjHZJiWQ for ; Fri, 25 Dec 2009 12:09:21 -0800 (PST) Received: from pivot.cs.unb.ca (pivot.cs.unb.ca [131.202.240.57]) by olra.theworths.org (Postfix) with ESMTP id 3C562431FAE for ; Fri, 25 Dec 2009 12:09:21 -0800 (PST) Received: from fctnnbsc30w-142167182194.pppoe-dynamic.high-speed.nb.bellaliant.net ([142.167.182.194] helo=localhost) by pivot.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1NOGTQ-0004ob-MN for notmuch@notmuchmail.org; Fri, 25 Dec 2009 16:09:20 -0400 Received: from bremner by localhost with local (Exim 4.71) (envelope-from ) id 1NOGTL-0006B2-As for notmuch@notmuchmail.org; Fri, 25 Dec 2009 16:09:15 -0400 From: david@tethera.net To: notmuch@notmuchmail.org Date: Fri, 25 Dec 2009 16:09:06 -0400 Message-Id: <1261771748-23687-1-git-send-email-david@tethera.net> X-Mailer: git-send-email 1.6.5.7 In-Reply-To: <87my17965l.fsf@anar.kanru.info> References: <87my17965l.fsf@anar.kanru.info> X-Sender-Verified: bremner@pivot.cs.unb.ca Subject: [notmuch] Update Patch Series. Only collapse part of citations. X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Dec 2009 20:09:22 -0000 On Fri, 25 Dec 2009 09:47:02 +0800, Kan-Ru Chen wrote: > I like this idea, but this patch hides all citations larger than the > threshold. I'd like to see limited lines of citations been displayed. Since you ask nicely, OK :). I kept it as two patches so that people could compare the usability of both versions. [PATCH 1/2] notmuch.el: Refactor citation markup. Variables for minimum size, button text. This is as before, except one stray '*' deleted from the regex for matching citations. This bug was only detected when I started partially hiding citations. [PATCH 2/2] notmuch.el: show some of citation even when hiding. This implements Kan-Ru's suggested format. I also changed the default text on the citation buttons so that it made a bit more sense when the citation was expanded. At first I thought having the buttons in the middle of an expanded citation would be really irritating, but I got used to it pretty quickly. So give it a chance ;). Hiding buttons or replacing them looks a bit messy to me. David