Date: Wed, 18 Jan 2012 12:35:34 -0500
From: Austin Clements <amdragon@MIT.EDU>
To: Tomi Ollila <tomi.ollila@iki.fi>
Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6
Message-ID: <20120118173534.GB16740@mit.edu>
References: <8739bea9lc.fsf@thor.loria.fr>
	<1326797453-9405-1-git-send-email-schnouki@schnouki.net>
	<1326797453-9405-2-git-send-email-schnouki@schnouki.net>
	<20120117222546.GT16740@mit.edu> <yf639bd5suz.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <yf639bd5suz.fsf@taco2.nixu.fi>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Tomi Ollila on Jan 18 at 10:15 am:
> On Tue, 17 Jan 2012 17:25:46 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
> > Quoth Thomas Jost on Jan 17 at 11:50 am:
> > >  
> > > +#ifdef GMIME_26
> > > +    /* sig_list may be created in both above cases, so we need to
> > > +     * cleanly handle it here. */
> > > +    if (node->sig_list) {
> > > +	GMimeSignatureList **proxy =
> > > +	    talloc (node, GMimeSignatureList *);
> > 
> > This doesn't need to be split into two lines.
> > 
> > > +	*proxy = node->sig_list;
> > > +	talloc_set_destructor (proxy, _signature_list_free);
> > > +    }
> > > +#else
> > >      if (node->verify_attempted && !node->sig_validity)
> > >  	fprintf (stderr, "Failed to verify signed part: %s\n",
> > >  		 (err ? err->message : "no error explanation given"));
> > > +#endif
> > 
> > I'd rather see the above as a separate #ifdef GMIME_26 and #ifndef
> > GMIME_26, since they aren't logical alternates of each other.
> 
> That reminds me that it should then be like GMIME_ATLEAST_26, so
> that this might be useful when GMIME > 2.6 is available...

Hopefully before GMIME 2.8 comes out, we'll be able to remove all of
the GMIME 2.4 compatibility.  But GMIME_ATLEAST_26 would be fine, too.