From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Adam Wolfe Gordon <awg@xvx.ca>, David Edmondson <dme@dme.org>
Subject: Re: [PATCH 4/4] emacs: Use the new JSON reply format.
In-Reply-To:
 <CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
References: <1326009162-19524-1-git-send-email-awg+notmuch@xvx.ca>
	<1326009162-19524-5-git-send-email-awg+notmuch@xvx.ca>
	<cun62gl1cqv.fsf@hotblack-desiato.hh.sledj.net>
	<CAMoJFUt8F417wzSmiHDv2KHa9y5ARYh=xRHKEsWBXYXHfaN64A@mail.gmail.com>
User-Agent: Notmuch/0.10.2+135~gb811a3c (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Thu, 12 Jan 2012 12:33:58 +0400
Message-ID: <87k44xgw09.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

Hi Adam.

On Mon, 9 Jan 2012 19:10:48 -0700, Adam Wolfe Gordon <awg@xvx.ca> wrote:
> Hi David,
>=20
> Thanks for the review.  Most of the things you've suggested are easy
> changes, and I think obvious improvements, so I'll change them for the
> next version.  A bit of discussion on the more involved things below:
>=20
> On Mon, Jan 9, 2012 at 01:50, David Edmondson <dme@dme.org> wrote:
> > On Sun, =C2=A08 Jan 2012 00:52:42 -0700, Adam Wolfe Gordon <awg+notmuch=
@xvx.ca> wrote:
> >> +(defun w3m-region (start end)) ;; From `w3m.el'.
> >> +(defun notmuch-mua-quote-part (part)
> >> + =C2=A0(with-temp-buffer
> >> + =C2=A0 =C2=A0(insert part)
> >> + =C2=A0 =C2=A0(message-mode)
> >> + =C2=A0 =C2=A0(fill-region (point-min) (point-max))
> >> + =C2=A0 =C2=A0(goto-char (point-min))
> >> + =C2=A0 =C2=A0(perform-replace "^" "> " nil t nil)
> >> + =C2=A0 =C2=A0(set-buffer-modified-p nil)
> >> + =C2=A0 =C2=A0(buffer-substring (point-min) (point-max))))
> >
> > Couldn't all of this be done directly in the reply buffer?
>=20
> Indeed, it could, I just hadn't thought of it.  I'll do this for the
> next version.
>=20
> > Using w3m means that you should `require' it. What happens when a user
> > doesn't have it? (Either the elisp or the command.)
>=20
> This was my initial thought, but when I looked at notmuch-show.el,
> which uses w3m features, I noticed that it doesn't have a require.  To
> be clear, this patch requires w3m.el (not just the w3m binary), which
> I don't think anything else in notmuch does.
>=20
> In the previous version I had a customize variable specifying whether
> to quote HTML parts, which meant that if the user could set the
> customize variable to false and everything would work without w3m.el.
> I'd like not to introduce a new prerequisite, so if there's a way to
> make w3m.el optional that would be my preference.  Can you provide
> some guidance on this?
>=20

I did not follow the rest of the discussion, so sorry if I missed
something obvious.  But why can't we render HTML parts in replies the
same way we do in notmuch-show (using `mm-display-part')?  That should
not introduce a w3m.el requirement, would use the same renderer as
configured for show and hence would produce consistent output in show
and reply.

Regards,
  Dmitry

> --=20
> Adam Wolfe Gordon
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch