From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: replace setq + let with let*
In-Reply-To: <878v2sv2zz.fsf@qmul.ac.uk>
References: <1370175370-13561-1-git-send-email-david@tethera.net>
	<1370185351-23834-1-git-send-email-david@tethera.net>
	<878v2sv2zz.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.15.2+141~gd298af4 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 02 Jun 2013 21:01:23 -0300
Message-ID: <874ndgt63w.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam_bar: -
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Jun 2013 00:01:37 -0000

Mark Walters <markwalters1009@gmail.com> writes:

>> -    (setq search (notmuch-hello-trim search))
>> -    (let ((history-delete-duplicates t))
>> +    (let* ((search (notmuch-hello-trim search))
>> +	   (history-delete-duplicates t))
>>        (add-to-history 'notmuch-search-history search)))
>>    (notmuch-search search notmuch-search-oldest-first nil nil
>
> These look good to me except I don't see why the above is a let* not a
> let?

I ended up dropping this hunk because I realized it introduced a bug;
the side-effect of the setq is needed outside the unless.

pushed the two patches (as amended) in this thread.

d