MIME-Version: 1.0
Sender: awg@xvx.ca
In-Reply-To: <87zka9b2zl.fsf@nikula.org>
References: <1334752753-23970-1-git-send-email-felipe.contreras@gmail.com>
	<1334752753-23970-3-git-send-email-felipe.contreras@gmail.com>
	<87zka9b2zl.fsf@nikula.org>
Date: Wed, 18 Apr 2012 11:27:50 -0600
Message-ID:
 <CAMoJFUvcd+-b6VR7Mg3qfccZ1TUy3puMb12gAyaqJ0fyVV4uMg@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] reply: add message-id header
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Jani Nikula <jani@nikula.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: notmuch@notmuchmail.org
Precedence: list

On Wed, Apr 18, 2012 at 07:09, Jani Nikula <jani@nikula.org> wrote:
> I do wonder whether the emacs ui / message mode will add a duplicate
> message-id rather than override this.

I think the emacs reply code will replace Message-ID and User-Agent
headers correctly, as it does with the From header when selecting a
different identity within emacs. But, this should be tested.

Ideally, the emacs tests should catch any problems here. As things are
right now, I think we would catch problems with the User-Agent header
in the reply tests: the tests replace the emacs and notmuch versions
with XXX but otherwise leave the header intact, so it should differ
from the one generated by notmuch compose.

The Message-ID is trickier, since in emacs it's generated when the
message is sent, not when the message is created, and thus the reply
tests don't see it at all. The "Sending a message via (fake) SMTP"
test could potentially catch problems, but currently the tests don't
try to predict the Message-ID emacs will give the message, so they
replace it with XXX.

-- Adam