From: Carl Worth <cworth@cworth.org>
To: Scott Robinson <scott@quadhome.com>, notmuch <notmuch@notmuchmail.org>
In-Reply-To: <1261114167-sup-8228@lisa>
References: <87iqcapijl.fsf@pivot.cs.unb.ca>
	<87k4wp2noq.fsf@yoom.home.cworth.org> <87skbdcfu3.fsf@pivot.cs.unb.ca>
	<1261114167-sup-8228@lisa>
Date: Fri, 18 Dec 2009 09:31:39 -0800
Message-ID: <87k4wkyyro.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [notmuch] [PATCH] JSON output for notmuch-search and
 notmuch-show.
Precedence: list

--=-=-=

On Thu, 17 Dec 2009 21:33:54 -0800, Scott Robinson <scott@quadhome.com> wrote:
> I took an earlier suggestion and didn't use cJSON, instead writing custom code
> for emitting the new format.

Nice! I have a few comments below.

> Added an "--output=(json|text|)" command-line option to both
> notmuch-search and notmuch-show.

I don't know why, but I think I'd prefer --format for the name here.

> In the case of notmuch-show, "--output=json" also implies
> "--entire-thread" as the thread structure is implicit in the emitted
> document tree.

It looks like the new documentation is missing that point, (and the man
page in notmuch.1 is missing an update as well).

> As a coincidence to the implementation, multipart message ID numbers are
> now incremented with each part printed. This changes the previous
> semantics, which were unclear and not necessary related to the actual
> ordering of the message parts.

That's just fine. The old numbering semantics were quite bizarre and
nothing I wanted to set it stone.

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLK7x76JDdNq8qSWgRAuSOAKCANgJ6gLQYCeFR4VqJTBM10+KKaQCeLu50
5+NcG1MAD8+waJuQgX9Bj6k=
=oUHF
-----END PGP SIGNATURE-----
--=-=-=--