Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 23482429E30 for ; Fri, 31 May 2013 17:40:22 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6w0ZUJ-z-4dL for ; Fri, 31 May 2013 17:40:14 -0700 (PDT) Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu [18.9.25.12]) by olra.theworths.org (Postfix) with ESMTP id 937B8431FBD for ; Fri, 31 May 2013 17:40:14 -0700 (PDT) X-AuditID: 1209190c-b7f566d000004c69-41-51a942eeaff6 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP id 05.73.19561.EE249A15; Fri, 31 May 2013 20:40:14 -0400 (EDT) Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r510eCOd032002; Fri, 31 May 2013 20:40:13 -0400 Received: from drake.dyndns.org (c-76-21-105-205.hsd1.ca.comcast.net [76.21.105.205]) (authenticated bits=0) (User authenticated as amdragon@ATHENA.MIT.EDU) by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r510e9jf020937 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Fri, 31 May 2013 20:40:12 -0400 Received: from amthrax by drake.dyndns.org with local (Exim 4.77) (envelope-from ) id 1UiZrd-0003QN-5Y; Fri, 31 May 2013 20:40:09 -0400 From: Austin Clements To: notmuch@notmuchmail.org Subject: [PATCH v3 0/6] Make Emacs search use sexp format Date: Fri, 31 May 2013 20:40:02 -0400 Message-Id: <1370047208-12785-1-git-send-email-amdragon@mit.edu> X-Mailer: git-send-email 1.7.10.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsUixCmqrfvOaWWgwbK5XBar5/JYXL85k9ni zcp5rA7MHjtn3WX3OPx1IYvHs1W3mAOYo7hsUlJzMstSi/TtErgy3vU+YirYJlBx6MJ+pgbG KzxdjBwcEgImEve6gExOIFNM4sK99WxdjFwcQgL7GCXm3t7EDuFsZJT4ePw/K4Rzmkli2/7v UM5cRokzi06ygPSzCWgAJZYzgtgiAtISO+/OZgWxmQUMJS5/7QCrERawlLh/8Q6YzSKgKvHx 8lawGl4BB4l7/98yQtyhKNH9bALbBEbeBYwMqxhlU3KrdHMTM3OKU5N1i5MT8/JSi3QN9XIz S/RSU0o3MYKDRZJnB+Obg0qHGAU4GJV4eDtWrQgUYk0sK67MPcQoycGkJMo723FloBBfUn5K ZUZicUZ8UWlOavEhRgkOZiUR3vw5QOW8KYmVValF+TApaQ4WJXHeyyk3/YUE0hNLUrNTUwtS i2CyMhwcShK8L0GGChalpqdWpGXmlCCkmTg4QYbzAA0/B1LDW1yQmFucmQ6RP8WoKCXOewEk IQCSyCjNg+uFRfMrRnGgV4R5uYGxLcQDTARw3a+ABjMBDX5ivRxkcEkiQkqqgbH7ZvfmzoQ3 +gvOnxLKskmWvGnguz68gGVZ/pF6nhnVpjE65mv4klIfrvf4NtGVt+3Xi2TLlZ1zdC0aN2js 2sJ0eJlv+cKpH0x+J03atnkaM69p1epnsccLOKt7Xe6+CcuOnJNUe2aij0jOHttbX/lcIn77 h19w+KKx/twPpfaMV5W73r9d0qnEUpyRaKjFXFScCACywxbewQIAAA== Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jun 2013 00:40:22 -0000 This is v3 of id:1369934016-22308-1-git-send-email-amdragon@mit.edu. This tweaks the shell invocation as suggested by Tomi and fixes two comment typos pointed out by Mark. It also adds a NEWS patch. I'm going to go ahead and mark this ready because of Tomi's and Mark's reviews of v2. The diff from v2 follows diff --git a/NEWS b/NEWS index 80abd97..2a4bde6 100644 --- a/NEWS +++ b/NEWS @@ -66,6 +66,17 @@ notmuch-vim, but of course that is their decision. Emacs Interface --------------- +Better handling of errors in search buffers + + Instead of interleaving errors in search result buffers, search mode + now reports errors in the minibuffer. + +Faster search results + + Communication between search mode and the notmuch CLI is now more + efficient because it uses the CLI's S-expression support. As a + result, search mode should now fill search buffers faster. + No Emacs 22 support The Emacs 22 support added late 2010 was sufficient only for a short diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index 180f63d..a206808 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -497,8 +497,8 @@ status." (command (or (executable-find notmuch-command) (error "command not found: %s" notmuch-command))) (proc (apply #'start-process name buffer - "sh" "-c" - "ERR=\"$1\"; shift; exec \"$0\" \"$@\" 2>\"$ERR\"" + "/bin/sh" "-c" + "exec 2>\"$1\"; shift; exec \"$0\" \"$@\"" command err-file args))) (process-put proc 'err-file err-file) (process-put proc 'sub-sentinel sentinel) @@ -533,8 +533,8 @@ status." (when warnings (notmuch-logged-error (car warnings) (cdr warnings))))) (error - ;; Emacs behaves strangely if error an error escapes from a - ;; sentinel, so turns errors into messages. + ;; Emacs behaves strangely if an error escapes from a sentinel, + ;; so turn errors into messages. (message "%s" (error-message-string err)))) (ignore-errors (delete-file err-file))))