From: Jani Nikula <jani@nikula.org>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [Patch v3b 6/9] test: update dump-restore roundtripping test for
	batch-tag format
In-Reply-To: <1354843607-17980-7-git-send-email-david@tethera.net>
References: <1354843607-17980-1-git-send-email-david@tethera.net>
	<1354843607-17980-7-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+138~g7041c56 (http://notmuchmail.org) Emacs/23.4.1
	(i686-pc-linux-gnu)
Date: Sat, 08 Dec 2012 00:56:01 +0200
Message-ID: <87obi5xyim.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: David Bremner <bremner@debian.org>
Precedence: list

On Fri, 07 Dec 2012, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> Now we can actually round trip these crazy tags and and message ids.
> hex-xcode is no longer needed as it's built in.
> ---
>  test/dump-restore |   17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/test/dump-restore b/test/dump-restore
> index b4c807f..ce81e6f 100755
> --- a/test/dump-restore
> +++ b/test/dump-restore
> @@ -99,23 +99,22 @@ notmuch dump --format=batch-tag from:cworth | sed 's/^.*-- id://' | \
>  test_expect_equal_file EXPECTED.$test_count OUTPUT.$test_count
>  
>  test_begin_subtest 'roundtripping random message-ids and tags'
> -    test_subtest_known_broken
> -    ${TEST_DIRECTORY}/random-corpus --config-path=${NOTMUCH_CONFIG} \
> -			--num-messages=10
>  
> -     notmuch dump| \
> -	 ${TEST_DIRECTORY}/hex-xcode --direction=encode| \
> +    ${TEST_DIRECTORY}/random-corpus --config-path=${NOTMUCH_CONFIG}
> +			--num-messages=100

What happened to the \ at the end of the line? Hmm, does it matter?

Otherwise, LGTM.

> +
> +     notmuch dump --format=batch-tag| \
>  	 sort > EXPECTED.$test_count
>  
>       notmuch tag +this_tag_is_very_unlikely_to_be_random '*'
>  
> -     ${TEST_DIRECTORY}/hex-xcode --direction=decode < EXPECTED.$test_count | \
> -	 notmuch restore 2>/dev/null
> +     notmuch restore --format=batch-tag < EXPECTED.$test_count
>  
> -     notmuch dump| \
> -	 ${TEST_DIRECTORY}/hex-xcode --direction=encode| \
> +     notmuch dump --format=batch-tag| \
>  	 sort > OUTPUT.$test_count
>  
>  test_expect_equal_file EXPECTED.$test_count OUTPUT.$test_count
>  
>  test_done
> +
> +# Note the database is "poisoned" for sup format at this point.
> -- 
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch