Return-Path: <keithp@keithp.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id AA754431FC0
	for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 10:11:09 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Q5hdUWbvIPv0 for <notmuch@notmuchmail.org>;
	Fri, 27 Nov 2009 10:11:08 -0800 (PST)
Received: from keithp.com (home.keithp.com [63.227.221.253])
	by olra.theworths.org (Postfix) with ESMTP id A2F85431FAE
	for <notmuch@notmuchmail.org>; Fri, 27 Nov 2009 10:11:08 -0800 (PST)
Received: from localhost (localhost [127.0.0.1])
	by keithp.com (Postfix) with ESMTP id C823F760093;
	Fri, 27 Nov 2009 10:11:07 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at keithp.com
Received: from keithp.com ([127.0.0.1])
	by localhost (keithp.com [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id 6ViHKTDj+cJp; Fri, 27 Nov 2009 10:11:05 -0800 (PST)
Received: by keithp.com (Postfix, from userid 1033)
	id E6BB576012E; Fri, 27 Nov 2009 10:11:04 -0800 (PST)
Received: from keithp.com (localhost [127.0.0.1])
	by keithp.com (Postfix) with ESMTP id B5E29760093;
	Fri, 27 Nov 2009 10:11:04 -0800 (PST)
From: Keith Packard <keithp@keithp.com>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
In-Reply-To: <87iqcwqgn5.fsf@yoom.home.cworth.org>
References: <yunvdh1nfwn.fsf@aiko.keithp.com>
	<87iqcwqgn5.fsf@yoom.home.cworth.org>
Date: Fri, 27 Nov 2009 10:10:58 -0800
Message-ID: <yun7htbet3h.fsf@aiko.keithp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Subject: Re: [notmuch] _notmuch_message_create_for_message_id makes extra
 call to notmuch_database_find_message
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2009 18:11:09 -0000

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 27 Nov 2009 04:46:54 -0800, Carl Worth <cworth@cworth.org> wrote:

> Did the "if" statement immediately afterwards just look like error
> checking? It's not:

Yes, it did (I think my brain may have auto-inserted a '!' there).

Ok, having read the code a bit more carefully, this does look correct.

I have to say that _notmuch_message_create is a bit of a tricky name; as
it doesn't create a message so much as load a message from the database.

=2D-=20
keith.packard@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLEBYyQp8BWwlsTdMRAvvgAKDeYKFEOL/YIxwX3aOa379QLVhFEQCgtlL8
ezeRSkBSjva7dVzOr797kUE=
=Qgn/
-----END PGP SIGNATURE-----
--=-=-=--