Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B3752407E8C for ; Tue, 6 Apr 2010 12:45:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.8 X-Spam-Level: X-Spam-Status: No, score=-2.8 tagged_above=-999 required=5 tests=[BAYES_05=-0.5, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gNUVR3ry58ci for ; Tue, 6 Apr 2010 12:45:58 -0700 (PDT) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by olra.theworths.org (Postfix) with ESMTP id C9BC1407E88 for ; Tue, 6 Apr 2010 12:45:58 -0700 (PDT) Received: from localhost ([::1] helo=localhost.localdomain) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NzEik-0004Gj-7I for notmuch@notmuchmail.org; Tue, 06 Apr 2010 19:45:58 +0000 Received: by localhost.localdomain (Postfix, from userid 500) id D9C34C007F; Tue, 6 Apr 2010 12:45:57 -0700 (PDT) From: Dirk Hohndel To: notmuch Subject: [PATCH 2/2] guess From address from Received headers Date: Tue, 06 Apr 2010 12:45:57 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2010 19:45:59 -0000 When replying to a message notmuch tries to pick the correct From address by looking which one of a user's configured email addresses were included in To or Cc headers of the email that is being replied to. If none of the users email addresses are in the To or Cc headers we now try to guess from the first (chronologically, last) Received header which domain this email was received in and therefore which of the email addresses to use in a reply If that fails we still use the primary email as From email Signed-off-by: Dirk Hohndel --- notmuch-reply.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 70 insertions(+), 3 deletions(-) diff --git a/notmuch-reply.c b/notmuch-reply.c index 6c15536..3c5b253 100644 --- a/notmuch-reply.c +++ b/notmuch-reply.c @@ -282,6 +282,69 @@ add_recipients_from_message (GMimeMessage *reply, return from_addr; } + +static const char * +guess_from_received_header(notmuch_config_t *config, notmuch_message_t *message) +{ + const char *received,*primary; + char **other; + char *by,*mta,*ptr,*token; + char *domain=NULL; + char *tld=NULL; + const char *delim=". \t"; + size_t i,other_len; + + received = notmuch_message_get_header (message, "received"); + by = strstr(received," by "); + if (by && *(by+4)) { + /* we know that there are 4 characters after by - either the 4th one + * is '\0' (broken header) or it is the first letter of the hostname + * that last received this email - which we'll use to guess the right + * from email address + */ + mta = strdup(by+4); + if (mta == NULL) + return NULL; + /* After the MTA comes its IP address (or HELO response) in parenthesis. + * so let's terminate the string there + */ + if ((ptr = strchr(mta,'(')) == NULL) { + free (mta); + return NULL; + } + *ptr = '\0'; + /* Now extract the last two components of the MTA host name + * as domain and tld + */ + token = mta; + while ((ptr = strsep(&token,delim)) != NULL) { + if (*ptr == '\0') + continue; + domain = tld; + tld = ptr; + } + if (domain) { + /* recombine domain and tld and look for it among the configured + * email addresses + */ + *(tld-1) = '.'; + primary = notmuch_config_get_user_primary_email (config); + if (strcasestr (primary, domain)) { + free(mta); + return primary; + } + other = notmuch_config_get_user_other_email (config, &other_len); + for (i = 0; i < other_len; i++) + if (strcasestr (other[i], domain)) { + free(mta); + return other[i]; + } + } + free(mta); + } + return NULL; +} + static int notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_t *query) { @@ -312,9 +375,13 @@ notmuch_reply_format_default(void *ctx, notmuch_config_t *config, notmuch_query_ g_mime_message_set_subject (reply, subject); from_addr = add_recipients_from_message (reply, config, message); - - if (from_addr == NULL) - from_addr = notmuch_config_get_user_primary_email (config); + + if (from_addr == NULL) { + from_addr = guess_from_received_header (config, message); + if (from_addr == NULL) { + from_addr = notmuch_config_get_user_primary_email (config); + } + } from_addr = talloc_asprintf (ctx, "%s <%s>", notmuch_config_get_user_name (config), -- 1.6.6.1 -- Dirk Hohndel Intel Open Source Technology Center