From: Carl Worth <cworth@cworth.org>
To: djcb@djcbsoftware.nl
In-Reply-To: <87638qbkbo.wl%djcb@djcbsoftware.nl>
References: <87r5rpyd4x.wl%djcb@djcbsoftware.nl>
	<87k4x6ad94.fsf@yoom.home.cworth.org>
	<87638qbkbo.wl%djcb@djcbsoftware.nl>
Date: Tue, 01 Dec 2009 19:01:24 -0800
Message-ID: <87aay29j0b.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: "notmuch@notmuchmail org" <notmuch@notmuchmail.org>
Subject: Re: [notmuch] [PATCH 2/2] * avoid gcc 4.4.1 compiler warning due to
 ignored 'fflush' return value
Precedence: list

--=-=-=

On Tue, 01 Dec 2009 20:50:03 +0200, Dirk-Jan C. Binnema <djcb.bulk@gmail.com> wrote:
> Sure, that's the better solution, but note that my patch did not introduce the
> undefined behavior -- it was there before. I was trying a minimal patch to
> silencing the warning.

Yes, the leak was my bug.

And the warning was useful to point to the bug. That's why silencing it
would have been a bad thing.

> Note that prompt seems to leak a bit, even after the
> committed patch; attached are two more micro patches to fix this and another
> small leak. I try to do minimal changes, but the prompt business gets a bit
> unwieldy. The leaks are one-time at not critical, but anyway it's always good
> stay vigilant.

Yes, leak fixes are always appreciated.

Could you resend these as complete git commits? I see only git diffs
which lack both authorship and commit messages.

Also, if you can send patches as text/plain rather than
application/octet-stream then it's much easier to review them by simply
replying and having the patch be quoted in the reply.

Thanks,

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLFdiF6JDdNq8qSWgRAi8AAJ40iKiiXGyQ+Kr5A+eoF1ZSg4OH8QCeM3oI
vd4FfixyUdtRMWVmlPoPxng=
=3Q1G
-----END PGP SIGNATURE-----
--=-=-=--