From: Carl Worth <cworth@cworth.org>
To: Pieter Praet <pieter@praet.org>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] fix sum moar typos
In-Reply-To: <1308600861-22684-1-git-send-email-pieter@praet.org>
References: <1307202852-4398-1-git-send-email-pieter@praet.org>
	<1308600861-22684-1-git-send-email-pieter@praet.org>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Thu, 23 Jun 2011 16:22:27 -0700
Message-ID: <8762nwdtfw.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Mon, 20 Jun 2011 22:14:21 +0200, Pieter Praet <pieter@praet.org> wrote:
> Various typo fixes in docs, docstrings, comments, etc...
>=20
> Signed-off-by: Pieter Praet <pieter@praet.org>

Thanks for these fixes, Pieter!

I've pushed these all out now. I split the original commit up into 6
commits that each touch different kinds of text, (non-code text files,
comments within source files, error messages within source files, etc.)

The idea there is that these different kinds of text have different
potential impacts on the correctness of the code. So some release
manager might be willing to include one kind of change, but not another,
for example.

Also, it made things a bit easier to read. There were two incorrect typo
fixes in the original commit which I fixed:

> -    "\tSeveral notmuch commands accept a comman syntax for search\n"
> +    "\tSeveral notmuch commands accept a command syntax for search\n"

This is now "common syntax".

> -    # Remember stdout and stderr file descriptios and redirect test
> +    # Remember stdout and stderr file descriptions and redirect test

This is now "file descriptors".

And one change where I left the original text unchanged:

>   * A non-NULL return value is guaranteed to be a valid string pointer
>   * pointing to the characters "new/" or "cur/", (but not
> - * NUL-terminated).
> + * NULL-terminated).

This comment uses "NULL" to describe a NULL pointer and "NUL" to
describe the ASCII character '\0'. (I know that "NUL" is a really
annoying historically misspelled abbreviation, but it is in standard
usage I believe---see ASCII(7) for example.)

Meanwhile, I was almost tempted to leave this misspelling unchanged:

> -	 (error "%s is a file. Can't creat maildir." path))
> +	 (error "%s is a file. Can't create maildir." path))

Since that's also a classic historically misspelled abbreviation. ;-)

Oh, and let me just thank you for being so thorough! There were several
fixes you made that could obviously not be caught by an automated spell
checker:

> ---part=3Did", (David Edmonson wants to rewrite some of "notmuch show" to
> +--part=3Did", (David Edmondson wants to rewrite some of "notmuch show" to
...
>  (defun notmuch-user-other-email ()
> -  "Return the user.primary_email value (as a list) from the notmuch conf=
iguration."
> +  "Return the user.other_email value (as a list) from the notmuch config=
uration."
...
>  (defcustom notmuch-after-tag-hook nil
> -  "Hooks that are run before tags of a message are modified.
> +  "Hooks that are run after tags of a message are modified.
...
> -The debian packaging exists in the top-level "debian" directory within
> +The Debian packaging exists in the top-level "debian" directory within

Those all demonstrate a particular eye for detail=E2=80=94well done! For a
couple of those, I almost gave them their own commits.

In passing, let me point out the most amusing typo I saw in the patch:

> -} /* Appleasing Emacs */
> +} /* Appeasing Emacs */

I almost hate to see that go, because I like the pleasing portmanteau
sound of "appleasing". Please applease me and leave this pleasing typo?

Admittedly, that's not in code that's originally mine, so I can't say it
wasn't intentional either.

Finally, *many* of the typos and misspellings were originally mine. It's
certainly embarrassing to see so many (and so many repeats). It was also
embarrassing to see how many misspellings I committed while typing the
commit messages, (fortunately I rebased many away).

And now I'm starting to get paranoid about this message. Am I really
brave enough to type words like "embarrassing", "misspelling", and
"committed" here?

Thanks again,

=2DCarl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk4DyrMACgkQ6JDdNq8qSWiqKQCfdc3+sNLZ54TX/WQo4l/GQC+o
jXIAn1Oiz1iIvRKgPVd0c50xySBjusmX
=Y2KO
-----END PGP SIGNATURE-----
--=-=-=--