From: David Bremner <david@tethera.net>
To: Nate Eagleson <nate@nateeag.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] build: Support Mac OS X 10.6.8
In-Reply-To: <1435699747-13591-2-git-send-email-nate@nateeag.com>
References: <1435699747-13591-1-git-send-email-nate@nateeag.com>
 <1435699747-13591-2-git-send-email-nate@nateeag.com>
User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.4.1
 (x86_64-pc-linux-gnu)
Date: Wed, 01 Jul 2015 08:07:48 +0200
Message-ID: <87egksjtqj.fsf@maritornes.cs.unb.ca>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

Nate Eagleson <nate@nateeag.com> writes:

> OS X 10.6.8 has a built-in library named libutil.dylib and a version
> of ld that picks that up instead of util/libutil.a.
>
> We now use an absolute path to util/libutil.a, so that notmuch can be
> built successfully on 10.6.8.

I'd like a one line subject that mentions libutil.a and perhaps
"absolute path"

>  
> +# Mac OS X 10.6 has a built-in libutil.dylib that prevents ld from
> +# picking up notmuch's libutil.a. The best way to prefer our local
> +# libutil.a is to specify it via absolute path, which should work on
> +# all supported OSes.
> +LIBUTIL_PATH=${srcdir}/util/libutil.a
> +

This needs to be relative to ${dir}, not ${srcdir} in order not to break
out of tree builds. You can test with

% mkdir -p /tmp/foo-build
% cd /tmp/foo-build
% ~/projects/notmuch/configure && make

Also, one Makefile gotcha is that anything using $(dir) should use :=
rather than = to force immediate expansion.

Cheers,

David