From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: bug in configure script
User-Agent: Notmuch/0.13+24~g16915cd (http://notmuchmail.org) Emacs/23.4.1
	(x86_64-pc-linux-gnu)
Date: Fri, 01 Jun 2012 11:17:05 -0700
Message-ID: <87pq9ivqvy.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=

There's a bug in the configure script that is causing auto-reruns of
./configure to not inherit original command line options if there was
more than one.  For instance, if I run:

./configure --with-gmime-version=2.4 --prefix=/home/jrollins/opt/notmuch

Then in Makefile.config I get:

configure_options = --with-gmime-version=2.4--prefix=/home/jrollins/opt/notmuch

This means that auto-reruns of configure will not get the proper
options.

I tracked this down to an issue with IFS and /bin/sh.  The first line of
./configure is:

readonly DEFAULT_IFS=$IFS

DEFAULT_IFS is then used to reset IFS after it is modified within the
script.  The problem is that /bin/sh is setting DEFAULT_IFS to be NULL
(i.e. ''), which leads to no separation between variables when "$@" is
expanded (which is itself problematic since I don't think "@" should use
the IFS when expanded).  So this might be a bug in dash.  I don't know.
In any event we need to fix this somehow.  I see two obvious solutions:

* use /bin/bash.  This a one line diff that fixes the problem
  immediately.

* replace:

    IFS=$DEFAULT_IFS

  with:

    unset IFS

  Unsetting IFS also resets IFS to the default, without going through
  this intermediate step.

I'm ok with either solution, but I'll wait for some feedback since I
imagine someone will have an opinion.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPyQchAAoJEO00zqvie6q8VlEP/AkYhn/YzNpESily/3dO1lfO
+XLDopIpGAI8Uf49T5MfPlWDRo/HGT1V85O+uZJrCT4Y4V6jxxbGxiejuZUUVQsA
gwcW0V34M0BN9kyDbJhjA/VUQcIt0gbG4NYo71hwS6fFMItjDIOZXc46WirLiueS
6SWcThQExzc6TXjtHkdhbaMhF0gTBslh+rrBO94SXJSyu7xlRTBUUG2ZBMlODEhw
xdzWiGiQAeOpLmYmMGWKZrVgBJxMorF1TOgvoBGiXoK/fJVoyTGjAPn0B9E5a3V0
sVdJAOgJHLnvsKL9vgJA1KdWXw80JWYfqI8FLXCrdq2TQArT/lBtpJ+B9d7DfTES
Uk+uo5pu+X/DpBShBwYPFtLuILoVyuPzvdcDXoDT4PRuaIIPn5MyjwKA7bDIW4lv
rjJ5ZZWrL3OWh5uXXN0i3wxc9XNgOFtPhRXhTiCTAmn4dU+FQC4I9/9oc0m+pRQm
1K9OH9U0sIMinXksEBxtrF9ZHFUE6SEtejnb4j1jL/VrxRaKIvkbDtvBrue053ve
R9XdcN5tpkqzDrKB6sM6ZMt1tQqPawigOTr5Ed1lxMgRl268ErncdX6Xe5fcnxB3
03pBYYwSPgMt+7JpN3U79Lqi/4mSjBF8zKxkVZzVwKauooZDMdWl48LOTdSe0q56
PgCyxPuqf25rK05l2PWN
=1jlW
-----END PGP SIGNATURE-----
--=-=-=--