To: Carl Worth <cworth@cworth.org>, notmuch <notmuch@notmuchmail.org>
Subject: Re: pull request
In-Reply-To: <87ljcj2u4z.fsf@yoom.home.cworth.org>
References: <87sk722sfq.fsf@ut.hh.sledj.net> <87eiibq22s.fsf@ut.hh.sledj.net>
	<87ljcj2u4z.fsf@yoom.home.cworth.org>
User-Agent: Notmuch/0.2-20-g89ec2c1 (http://notmuchmail.org) Emacs/23.1.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 20 Apr 2010 06:27:02 +0100
Message-ID: <8739yq8zix.fsf@ut.hh.sledj.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon, 19 Apr 2010 11:07:40 -0700, Carl Worth <cworth@cworth.org> wrote:
> >  commit 8586a86b9dd4ed2406a2fbda6c08bdc6a598cfd8
> >     debian: git should ignore packaging intermediate files
> 
> I committed an alternate version of this, (with a new debian/.gitignore
> file). I used more wildcarding too. And I couldn't actually find how to
> make all these files appear. If you need more ignores, just let me know
> (and let me know what commands trigger those, since I'm curious).

>From memory I ran 'debuild'.

> > commit 53c4e64943d09b07e75c9258fc9f954c87a490d6
> >     json: Avoid calling strlen(NULL)
> 
> That commit message describes this hunk of the patch:
> 
> > +    if (str == NULL)
> > +       str = "";
> > +
> >     return (json_quote_chararray (ctx, str, strlen (str)));
> 
> But this other hunk looks independent. What's going on here?
> 
> > -    if (len == 0)
> > -       return (char *)"\"\"";
> > -
> 
> So I haven't committed this piece yet.

The second chunk was intended to cover a similar case (len == 0), but
becomes unnecessary after the first chunk. At least, that's what I
convinced myself after the conversation with Anthony Towns
(id:h2y87b3a4191004060117v5421db8ejbe3030d0626e7440@mail.gmail.com).

dme.
-- 
David Edmondson, http://dme.org