To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.
In-Reply-To: <yf6zkdlawlc.fsf@taco2.nixu.fi>
References: <87pqei327k.fsf@gmail.com>
	<1326809224-22673-1-git-send-email-dme@dme.org>
	<1326809224-22673-2-git-send-email-dme@dme.org>
	<yf6zkdlawlc.fsf@taco2.nixu.fi>
User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Thu, 19 Jan 2012 09:59:16 +0000
Message-ID: <cunzkdk57yj.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed, 18 Jan 2012 16:55:59 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> > +	# Report success/failure.
> > +	if ! test_skip "$test_subtest_name"
> > +	then
> > +		if [ "$result" =3D=3D t ]
>=20
> 		if [ "$result" =3D t ]
>=20
> to be compatible with POSIX and consistent with rest code.

I'm happy to change this.

> > +			test_failure_ "$test_subtest_name" "$(eval printf ${result})"
>=20
> This added 'eval' made me investigate further... running=20
>=20
> emacsclient --eval '(print (concat "a" "b" "\t" "c" "\n" "z"))'
>=20
> outputs "ab	c\nz" (tab between 'ab' and 'c', quotes (") around
> the whole output and newlines as "\n" (even '\r' is converted)).
>=20
> If emacs tests run via test_emacs_expect_t wrote their output=20
> to ${output} directly above code could be much cleaner in many
> places. Environment variable could be used for the file name.

I'm reluctant to change this just to avoid calling eval.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8X6XQACgkQaezQq/BJZRbEtwCfZ/d6vTlUusa5YwUx0VOrWU7w
nJoAnjxBjfNQho4/Uvb6MAmokuzU+eM6
=IHUl
-----END PGP SIGNATURE-----
--=-=-=--