Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 9C726431FAF for ; Wed, 26 Dec 2012 06:55:17 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GjNZD3CmTbz4 for ; Wed, 26 Dec 2012 06:55:17 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 17C2A431FAE for ; Wed, 26 Dec 2012 06:55:17 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TnsO0-0002X1-76; Wed, 26 Dec 2012 10:55:12 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TnsNu-0007TF-Jb; Wed, 26 Dec 2012 10:55:06 -0400 From: David Bremner To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 0/5] Use Xapian query syntax for batch-tag dump/restore In-Reply-To: <1356493723-11085-1-git-send-email-amdragon@mit.edu> References: <1356493723-11085-1-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Wed, 26 Dec 2012 10:55:06 -0400 Message-ID: <87ehicrhh1.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2012 14:55:17 -0000 Austin Clements writes: > This obsoletes > > id:1356415076-5692-1-git-send-email-amdragon@mit.edu > > In addition to incorporating all of David's suggestions, this reworks > the boolean term parsing so it only handles the subset of quoting > syntax used by make_boolean_term (which also happens to be all that we > described in the man page for the format). The diff from v1 is below. Implementation wise this series now looks OK to me; I think the dequote routine could be slightly clearer, but it's a bit subjective at this point. IMHO the real question is if we like (or can live with) the resulting UI for batch tagging. Mark ( id:87ehid5h64.fsf@qmul.ac.uk ) brings up the question of whether tags with newlines should be somehow supported in a batch-tagging context. The other UI issue I'm aware of is the fact that tags with spaces needed to be quoted in two different ways for tag operations and for queries. A relatively smooth upgrade path would be to support Xapian quoting for tag operations in the future. d