From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>, Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH v3 05/16] Use a blank _notmuch_crypto to choose the
 default gpg_path
In-Reply-To: <87oabovl7h.fsf@maritornes.cs.unb.ca>
References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net>
 <1454272801-23623-6-git-send-email-dkg@fifthhorseman.net>
 <87oabovl7h.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Wed, 10 Feb 2016 11:37:52 -0500
Message-ID: <877fico71b.fsf@alice.fifthhorseman.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Wed 2016-02-10 06:49:54 -0500, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>> This way we're only choosing a default in one place.
>> ---
>>  notmuch-config.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/notmuch-config.c b/notmuch-config.c
>> index d252bb2..7cd19a7 100644
>> --- a/notmuch-config.c
>> +++ b/notmuch-config.c
>> @@ -418,7 +418,8 @@ notmuch_config_open (void *ctx,
>>      }
>>  
>>      if (notmuch_config_get_crypto_gpg_path (config) == NULL) {
>> -	notmuch_config_set_crypto_gpg_path (config, "gpg");
>> +	_notmuch_crypto_t crypto = { .gpg_path = NULL };
>> +	notmuch_config_set_crypto_gpg_path (config, _notmuch_crypto_get_gpg_path (&crypto));
>>      }
>
> I'm not sure if it's worth it, but this particular usage would be
> cleaner if _notmuch_crypto_get_path allowed a NULL argument.

Agreed; this change will be in my v4 series.

        --dkg