Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5F83B429E25 for ; Sat, 12 Nov 2011 02:02:19 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5caut7ue2Nil for ; Sat, 12 Nov 2011 02:02:18 -0800 (PST) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id A2E70431FB6 for ; Sat, 12 Nov 2011 02:02:18 -0800 (PST) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pACA28nN005072; Sat, 12 Nov 2011 12:02:08 +0200 From: Tomi Ollila To: Austin Clements , Tomi Ollila Subject: Re: [PATCH] test: attempt to send QUIT to smtp-dummy in case mail send failed In-Reply-To: <20111112024941.GY2658@mit.edu> References: <20111112024941.GY2658@mit.edu> User-Agent: Notmuch/0.9+23~g556c5fa (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Nov 2011 10:02:19 -0000 On Fri, 11 Nov 2011 21:49:41 -0500, Austin Clements wrote: > Good idea, but this introduces a dependency on netcat. Would it work > to simply kill the SMTP dummy? I cannot guarantee 6 nines of probability (but can guarantee as many eights as one migh wish ;) Socket buffering and timing might cause smtp dummy to be killed before it has read all content... But... i recall bash has a way to do tcp stuff .../dev/tcp/host/port is mentioned in manual page. I'll investigate this later (or, anyone of you, provide a patch :) Tomi > Quoth Tomi Ollila on Nov 11 at 1:38 am: > > If mail sending from emacs fails before it has chance to connect > > to the smtp-dummy mail server, the opportunistic QUIT message > > sending makes smtp-dummy to exit. > > --- > > test/test-lib.sh | 8 +++++--- > > 1 files changed, 5 insertions(+), 3 deletions(-) > > > > diff --git a/test/test-lib.sh b/test/test-lib.sh > > index af723ad..57cb088 100755 > > @@ -397,6 +397,8 @@ emacs_deliver_message () > > (insert \"${body}\") > > $@ > > (message-send-and-exit))" >/dev/null 2>&1 > > + # opportunistically quit smtp-dummy in case above fails. > > + echo QUIT | nc 127.0.0.1 25025 >/dev/null 2>&1 > > wait ${smtp_dummy_pid} > > notmuch new >/dev/null > > } > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch >