Return-Path: <daniel.schoepe@googlemail.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 0053F431FD0
	for <notmuch@notmuchmail.org>; Thu,  7 Jul 2011 01:15:59 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.789
X-Spam-Level: 
X-Spam-Status: No, score=-0.789 tagged_above=-999 required=5
	tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
	FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, T_MIME_NO_TEXT=0.01]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id hjf-4vvTgLvd for <notmuch@notmuchmail.org>;
	Thu,  7 Jul 2011 01:15:59 -0700 (PDT)
Received: from mail-fx0-f46.google.com (mail-fx0-f46.google.com
	[209.85.161.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 2E98D431FB6
	for <notmuch@notmuchmail.org>; Thu,  7 Jul 2011 01:15:59 -0700 (PDT)
Received: by fxh19 with SMTP id 19so862505fxh.19
	for <notmuch@notmuchmail.org>; Thu, 07 Jul 2011 01:15:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=from:to:subject:in-reply-to:references:user-agent:date:message-id
	:mime-version:content-type;
	bh=ItWPlIkdRK+uFpm06ITKwLJjRgDrS6FKhcZAyJ3nvk4=;
	b=pw1XtWLkWCb0CHLZcxeGx5NCij9tu1rzuPBisplC3Vu7otev1vHgqoCRbcECgGkTcY
	XJHJ8lGo/KEOkA31soNca5Yuhtc05gYeaIEUth3ePfrwC/436TKkr/OK0os3nOdmeMqC
	zYgDHRzuAiBIrzjGDQ94jYpBNkeYWeva1Hbac=
Received: by 10.223.59.92 with SMTP id k28mr853744fah.27.1310026557770;
	Thu, 07 Jul 2011 01:15:57 -0700 (PDT)
Received: from localhost (dslb-088-069-138-212.pools.arcor-ip.net
	[88.69.138.212])
	by mx.google.com with ESMTPS id n27sm6557890faa.4.2011.07.07.01.15.55
	(version=TLSv1/SSLv3 cipher=OTHER);
	Thu, 07 Jul 2011 01:15:56 -0700 (PDT)
From: Daniel Schoepe <daniel.schoepe@googlemail.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons
	for notmuch searches
In-Reply-To: <87r5624l3g.fsf@gmail.com>
References: <1309896760-378-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309961881-28333-1-git-send-email-daniel.schoepe@googlemail.com>
	<1309961881-28333-2-git-send-email-daniel.schoepe@googlemail.com>
	<87r5624l3g.fsf@gmail.com>
User-Agent: Notmuch/0.5-321-g7d7ebd8 (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Thu, 07 Jul 2011 10:15:47 +0200
Message-ID: <87vcve1p70.fsf@tredergarh.home.box>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jul 2011 08:16:00 -0000

--=-=-=

Hi Dmitry,

On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Why do we need to remove `goto-address-mode' overlays if it is not
> enabled ((goto-address-mode t) is below is removed)?
> [..]
> `goto-address-mode' creates buttons not only for email addresses but
> also for URLs.  Do we loose it now?

Everything `goto-address-mode' does is still in effect, I just replaced
(goto-address-mode t) by a call to `goto-address-fontify-region' in
notmuch-show-buttonise-links, to ensure that the id links will be
buttonised (and the overlay removed after it's actually been inserted)
_after_ goto-address does its thing.

I could also have left (goto-address-mode t) in and jit-register-lock'ed
notmuch-show-buttonise-links before that, but then I would be relying on
the fact that fontifiers that are registered first, will be run last. As
far as I can tell this is just an implementation detail and might change
some day.

Cheers,
Daniel

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBAgAGBQJOFWszAAoJEIaTAtce+Z+JN4kP/jzsMHUYqcHAUUpSqOtcozLR
vOAxX3dfkYdRE+77GC0hJ7q/mPjM9wU1o712Gfp4hfpo6C4Y8AED5hhvg4EoG40k
5znNTBwC8HD4HwSs1s2rdZ0OsARD24/j71L27mVfaF25ssUo+WhMu1i2DmivxZ4j
eC8C1gUP9FGAlxnO0dO/XVeo5a7+ACpEoIRFBhq/BP5fmXJibW4NfJwHEHT9++YO
b3/Dfsu990spuUWJpsVYyIG39PXrbmMI9WBpfDkn0W/d/ZMmoJziLf9kbsjEov7E
xoM6V2AxMGrUsjDrUntZJLgFUFOKHJ5/Lyft3aMPiyJ4Oh+ch3toxgqnNVZkJnEr
1njIW/GIKXhs2pP5rzCZrSRpb2BfUYkrB+Xvw2DlJ8s69cBWe6g6pSIBOxm2vDG2
LGzQM3j4Cu92MDu/YOj5mevZvZ37PI6Vfh5PekJ30j9Qy7R9hL6CbUSgAIGsZpES
1n/MdnIpEXQLSqTgaEzSSUxG2PfFs4l9vYC0HN2oz3qkemw9rMKjgmbG/l2HWb8Z
2A3t7gjgWToe+qxVQJXEYh4KT1lazT7hZuQt9G4F6E5gfl60nMa7FJUAVU8Xz3hS
AMuxkx1mJifedyxwHNusnbO9/YtZeD5jckTiK/qUwSXfj/pLjwBmWSUTwcpGUzY2
cnv+UR2Tsd6EpmPb1WE/
=utPo
-----END PGP SIGNATURE-----
--=-=-=--