Date: Sat, 14 Sep 2013 16:55:09 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH] emacs: bugfix unquoted symbol
Message-ID: <20130914205508.GW1426@mit.edu>
References: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: notmuch@notmuchmail.org
Precedence: list

Definitely LGTM.

Quoth Mark Walters on Sep 14 at  9:17 pm:
> In the recent changes for search order handling the default-value of
> notmuch-search-oldest-first was used. However, default-value needs a
> symbol so the symbol-name needs to be quoted.
> 
> This missing quote was causing strange sort-orders in some cases.
> ---
> 
> I think this is clearly correct (and what was intended) and it seems
> to work as expected.
> 
> Best wishes
> 
> Mark
> 
> 
> 
> 
>  emacs/notmuch.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 4de6229..0ff248b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -888,7 +888,7 @@ the configured default sort order."
>      nil
>      ;; Use the default search order (if we're doing a search from a
>      ;; search buffer, ignore any buffer-local overrides)
> -    (default-value notmuch-search-oldest-first)))
> +    (default-value 'notmuch-search-oldest-first)))
>  
>    (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
>  	 (buffer (get-buffer-create (notmuch-search-buffer-title query))))