Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 40D8E431FD0 for ; Tue, 5 Jul 2011 13:23:15 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.001 X-Spam-Level: X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 tests=[FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c1Ef3XRUrsgK for ; Tue, 5 Jul 2011 13:23:14 -0700 (PDT) Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3]) by olra.theworths.org (Postfix) with ESMTP id 5E6BA431FB6 for ; Tue, 5 Jul 2011 13:23:12 -0700 (PDT) Received: from matthieu-netbook (unknown [82.239.207.166]) by smtp3-g21.free.fr (Postfix) with ESMTP id 7D157A620B; Tue, 5 Jul 2011 22:23:07 +0200 (CEST) From: Matthieu Lemerre To: Jameson Graef Rollins , Robin Green , Notmuch Mail Subject: Re: Dangerous space bar key (was: Preventing the user shooting themself in the foot) In-Reply-To: <87pqlpioew.fsf@servo.factory.finestructure.net> References: <86iproe86u.fsf@greenrd.plus.com> <877h7xafto.fsf@free.fr> <87pqlpioew.fsf@servo.factory.finestructure.net> User-Agent: Notmuch/0.6+mwhudson+1700~natty1 (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Tue, 05 Jul 2011 22:23:05 +0200 Message-ID: <87wrfwpjdi.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2011 20:23:15 -0000 On Mon, 04 Jul 2011 17:03:51 -0700, Jameson Graef Rollins wrote: Non-text part: multipart/signed > On Mon, 04 Jul 2011 23:36:35 +0200, Matthieu Lemerre wrote: > > I like to use the space (and sometimes the backspace key) to read > > threads back and forth, but sometimes I might read stuff to quickly and > > archive a thread without wanting it. It is then complex to find it back > > (especially if the thread contained a single message and I hit space > > before actually reading the message, so I can't find it again). > > > > As a workaround, I have changed the space key function > > "notmuch-show-advance-and-archive" to not archive the thread if we are > > at the end of the thread, but to just do nothing. Thus I have to > > expicitely archive the thread when I have finished reading it, which I > > find much safer. > > I completely agree with your discomfort with the current function bound > to space. I don't like it at all, and I similarly rebound space to be a > much more sensible function: [...] > Notice I also made it so that this does not exit the current thread > view. I patched notmuch to use exactly the same function... Given that we are two people who independently requested for this behaviour, I think this should at least be a customisable option, and imo the default should do nothing and not archive the thread because of this dangerous behaviour. And, hitting 'a' instead of space to go to the next thread is the same number of keypresses... Matthieu