From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 00/11] notmuch insert updates
In-Reply-To: <878ul815jf.fsf@maritornes.cs.unb.ca>
References: <cover.1411379395.git.jani@nikula.org>
	<878ul815jf.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.18.1+97~g6c845ef (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Thu, 25 Sep 2014 22:54:53 +0300
Message-ID: <m24mvvpjaq.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Thu, Sep 25 2014, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>
>> This series refactors and cleans up insert, improves error handling and
>> reporting, and adds post-insert hook. I intend to add documentation and
>> more tests, but the code is ready for review. Also, at least some of the
>> cleanups and fixes in the beginning of the series could go in without
>> additional tests or documentation.
>
> The first 4 seem trivial, and I marked them so.
>
> 5-8 don't introduce new functionality, and don't break 
> any existing tests. Subject to a little more review, these could 
> probably be merged now.
>
> 5 is almost trivial; it wouldn't hurt to explicitly document the return
> values of sync_dir, while touching this code.
>
> 6 and 8 seem ok, but should probably have another pair of eyes.
>
> 7 seems ok. At first I worried about the usual issue of races between
> name definition and open, but it seems like nothing changes here.

5-8 in this series LGTM.

Tomi