Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EC68E429E54 for ; Mon, 23 Jan 2012 10:51:12 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TTfuZG22Z04G for ; Mon, 23 Jan 2012 10:51:12 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 70185429E21 for ; Mon, 23 Jan 2012 10:51:12 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id 0C30C66E0089; Mon, 23 Jan 2012 10:51:12 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (gwave-110.ligo.caltech.edu [131.215.114.110]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 25A5066E0145; Mon, 23 Jan 2012 10:51:09 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id E750D34F; Mon, 23 Jan 2012 10:51:08 -0800 (PST) From: Jameson Graef Rollins To: David Edmondson , Notmuch Mail Subject: Re: [PATCH 4/6] emacs: add option to notmuch-show-next-open-message to pop out to parent buffer if at end In-Reply-To: References: <87pqea24z0.fsf@servo.finestructure.net> <1327307665-23387-1-git-send-email-jrollins@finestructure.net> <1327307665-23387-2-git-send-email-jrollins@finestructure.net> <1327307665-23387-3-git-send-email-jrollins@finestructure.net> <1327307665-23387-4-git-send-email-jrollins@finestructure.net> <87d3aa1fot.fsf@servo.finestructure.net> User-Agent: Notmuch/0.11+102~g958863a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Mon, 23 Jan 2012 10:51:06 -0800 Message-ID: <87aa5e1cdh.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 18:51:13 -0000 --=-=-= On Mon, 23 Jan 2012 17:55:14 +0000, David Edmondson wrote: > On that basis, I hope no-one will complain if I fix them as a 'drive by' > during another change... Hrm. I don't think that follows. Unless the patch is already touching that code, I would really prefer we continue to enforce that unrelated changes go into separate patches. There are plenty of other places in the code where we do use parens around uninitialized variables. If you really want to remove them I would prefer to see a patch to fixes them all at once. Doesn't seem worth it to me, but everyone seems to be on an uncrustify kick recently, so... jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPHawaAAoJEO00zqvie6q8VqgP/06EV3X8fqsIIJxYRzZsqAgJ 5Qy6I7JBsjcmYPlV8uAp0P8Omv4ETL+Hd1sk3ghsYQKjcdNnkNJyfMrzZIO5U4Ia bP6xofEU/Xl+V6xfburOZnawIwQSU6mTe2bwnz2Ra6ojCwCI+Of8kj4GQqVa07I4 VZiwuYUOCZeVHw+2YMPnLKuHaCBKdZDeD7db+ffDX41v6Ggfc3Ro816KfShYSOIC DjFx29kwUfYKUMn+o7eHVgbvfzRzlSail19WUwfbuU8Y1Efz40uX7jBil2euxfUw dkcemkZXRuGz3d9p1aPww9wcNsDQC4kIQ290ZiL91MzBg472v+fuP+/zrzrEjtSX P2tEGW/65znPeXLt8dOjS2cFHTHV3ix3Gl8m/p4OCnFz4zWNis7bsLa+7Fgzqtdn W1aJiDjHoK+nyZq4RQwUOiJW8mzarK7PBd9iFTRW+HDFCiOCwltJDGZa8iXGKAy4 PtUQjSfdzVbmA/T86U1rMRhwzFH8xKmUdcPnyzJV3m5VTm97FYn8jUMVIMgbEUlE PgIqpHNfyezpDBJZEHIXiZxBw4JDDM8LrgpPy3y+/oiAoSTaRsI1BGIYluuiaMCT pel43owFK0AnPtDUAyrS8NF8RrYnPPIf8PkUpUtDdO7sLKIM6rSmlTAfljsOG1rv QDpnFe7CBC5reYui9J29 =gQ3w -----END PGP SIGNATURE----- --=-=-=--