Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 21874431FC0 for ; Sat, 10 May 2014 03:42:05 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oZt8OiJCpCuU for ; Sat, 10 May 2014 03:41:56 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 99A0E431FBF for ; Sat, 10 May 2014 03:41:56 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id C6FC71000E5; Sat, 10 May 2014 13:41:48 +0300 (EEST) From: Tomi Ollila To: =?utf-8?B?WMSrY8Oy?= , notmuch@notmuchmail.org Subject: Re: [PATCH] Fallback check for zlib. In-Reply-To: <87r4423rf8.fsf@maritornes.cs.unb.ca> References: <874n0y5qo5.fsf@maritornes.cs.unb.ca> <1399700023-8041-1-git-send-email-xico@atelo.org> <1399700023-8041-2-git-send-email-xico@atelo.org> <87r4423rf8.fsf@maritornes.cs.unb.ca> User-Agent: Notmuch/0.18+11~gbc95cc5 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 May 2014 10:42:05 -0000 On Sat, May 10 2014, David Bremner wrote: > X=C4=ABc=C3=B2 writes: > >> --- >> compat/have_zlib.c | 6 ++++++ >> configure | 21 ++++++++++++++++----- >> 2 files changed, 22 insertions(+), 5 deletions(-) >> create mode 100644 compat/have_zlib.c > > If you're doing a second version for Tomi's comments, please put roughly > the comments from the cover letter in the commit message of the actual > patch; or at least be more verbose there. True, I failed to notice lack of commit message as the patch was so shiny ;) > Cheers, > > d Tomi