From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Move the blank line from the bottom of the headers
	to the top of the body.
In-Reply-To: <1327942340-23340-1-git-send-email-dme@dme.org>
References: <1327942340-23340-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 31 Jan 2012 15:41:05 +0400
Message-ID: <87vcnsm75a.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon, 30 Jan 2012 16:52:20 +0000, David Edmondson <dme@dme.org> wrote:
> The blank line doesn't really change position, but is now considered
> to be part of the body rather than part of the headers. This means
> that it is visible when the body is visible rather than when the
> headers are visible.
> ---
> 
> I'm interested in getting feedback on this.
> 
> Unless you run with `notmuch-message-headers-visible' set to `nil' or
> regularly toggle header visibility, you probably don't care.
> 

+1

Regards,
  Dmitry

>  emacs/notmuch-show.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 84ac624..73f73d4 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -854,8 +854,6 @@ current buffer, if possible."
>      ;; compatible with the existing implementation. This just sets it
>      ;; to after the first header.
>      (notmuch-show-insert-headers headers)
> -    ;; Headers should include a blank line (backwards compatibility).
> -    (insert "\n")
>      (save-excursion
>        (goto-char content-start)
>        ;; If the subject of this message is the same as that of the
> @@ -870,6 +868,8 @@ current buffer, if possible."
>      (setq notmuch-show-previous-subject bare-subject)
>  
>      (setq body-start (point-marker))
> +    ;; A blank line between the headers and the body.
> +    (insert "\n")
>      (notmuch-show-insert-body msg (plist-get msg :body) depth)
>      ;; Ensure that the body ends with a newline.
>      (unless (bolp)
> -- 
> 1.7.8.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch