Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id F0A0C6DE14FD for ; Mon, 27 Jul 2015 12:36:47 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.955 X-Spam-Level: X-Spam-Status: No, score=0.955 tagged_above=-999 required=5 tests=[AWL=0.303, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L1Wc9mhUF0pp for ; Mon, 27 Jul 2015 12:36:45 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 0952B6DE14D9 for ; Mon, 27 Jul 2015 12:36:45 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 27AB8100086; Mon, 27 Jul 2015 22:36:24 +0300 (EEST) From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] build: add "set -e" to version script generation In-Reply-To: <1438022552-24342-1-git-send-email-david@tethera.net> References: <1438022552-24342-1-git-send-email-david@tethera.net> User-Agent: Notmuch/0.20.2+31~g967a7a3 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2015 19:36:48 -0000 On Mon, Jul 27 2015, David Bremner wrote: > It turns out that on certain systems like FreeBSD, c++filt is not > installed by default. It's basically OK if we fail the build in that > case, but what's really not OK is for the build to continue and > generate bad binaries. > --- > lib/gen-version-script.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh > index 64a7374..aa1ca43 100644 > --- a/lib/gen-version-script.sh > +++ b/lib/gen-version-script.sh > @@ -1,3 +1,4 @@ > +set -e LGTM, although I'd prefer 'set -eu' (both visual observation and testing with set -eux worked for me). Tomi > > # we go through a bit of work to get the unmangled names of the > # typeinfo symbols because of > -- > 2.1.4 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch