Return-Path: <david@tethera.net>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 86DA96DE025F
 for <notmuch@notmuchmail.org>; Thu, 24 Sep 2015 05:42:28 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.483
X-Spam-Level: 
X-Spam-Status: No, score=0.483 tagged_above=-999 required=5 tests=[AWL=-0.261,
  URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id Q4Rof7yFps_l for <notmuch@notmuchmail.org>;
 Thu, 24 Sep 2015 05:42:23 -0700 (PDT)
Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
 by arlo.cworth.org (Postfix) with ESMTPS id D552E6DE0B7C
 for <notmuch@notmuchmail.org>; Thu, 24 Sep 2015 05:42:22 -0700 (PDT)
Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
 (envelope-from <david@tethera.net>)
 id 1Zf5pD-0006hs-Iv; Thu, 24 Sep 2015 12:40:35 +0000
Received: (nullmailer pid 17665 invoked by uid 1000); Thu, 24 Sep 2015
 12:40:16 -0000
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 6/9] cli: change the data structure for notmuch
 address deduplication
In-Reply-To: <87fv242e2a.fsf@zancas.localnet>
References: <cover.1441308761.git.jani@nikula.org>
 <d8bb01aff648f9b73ec5f09f0e86e42dac2a21a6.1441308761.git.jani@nikula.org>
 <87fv242e2a.fsf@zancas.localnet>
User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1
 (x86_64-pc-linux-gnu)
Date: Thu, 24 Sep 2015 09:40:16 -0300
Message-ID: <87bncs2dov.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Sep 2015 12:42:28 -0000

David Bremner <david@tethera.net> writes:

> Jani Nikula <jani@nikula.org> writes:
>
>
>> +    else
>> +	v = !!m1->name - !!m2->name;
>
> Is this really idiomatic? It seems a little difficult to follow to me.
>

Sorry, this stupid MUA I'm using confused me and I sent the reply
halfway through reading the patch. Anyway, the rest looks OK.

d