To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of
	notmuch-show-mode.
In-Reply-To: <20111225010635.GG1927@mit.edu>
References: <id:"1324553312-10972-1-git-send-email-dme@dme.org">
	<1324665712-2419-1-git-send-email-dme@dme.org>
	<20111225010635.GG1927@mit.edu>
User-Agent: Notmuch/0.10.2+107~ga2d0215 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Mon, 26 Dec 2011 10:49:46 +0000
Message-ID: <cunlipztxo5.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 24 Dec 2011 20:06:35 -0500, Austin Clements <amdragon@MIT.EDU> wrot=
e:
> Awesome.  This looks significantly cleaner.  I think this is worth
> pushing for the comment you added to notmuch-show-advance alone.

Thanks.

> This definitely changes the behavior of rewind, but other than one
> case I point out below, I think what you have now is much closer to an
> inverse of advance.  It would be nice to have tests for rewind (looks
> like we don't have any right now), but it would seem counterproductive
> to write tests for the current rewind only to rewrite them for this
> rewind.

I'll write some tests.

> Tailing whitespace.

Will fix.

> > +     ((=3D start-of-message (point))
> > +      ;; The cursor is at the start of the current message - move to
> > +      ;; the previous open message.
> > +      (notmuch-show-previous-open-message))
>=20
> This will jump to the beginning of the previous message if I'm at the
> beginning of a message.  I would expect rewind to show me the end of
> the previous message in this case.

That would definitely more closely be the inverse of how advance works,
but is it the most useful behaviour?

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk74UUoACgkQaezQq/BJZRY0EgCfTd7GM9CehP0QMraC/KeIQ11m
o8wAnAygHiD2jJddvPaV19dgetFmcGuU
=Gyn2
-----END PGP SIGNATURE-----
--=-=-=--