From: Jameson Graef Rollins <jrollins@finestructure.net>
To: david@tethera.net, notmuch@notmuchmail.org
Subject: Re: [PATCH 5/7] CLI: add --leak-report top level option
In-Reply-To: <1358619958-21209-6-git-send-email-david@tethera.net>
References: <1358619958-21209-1-git-send-email-david@tethera.net>
	<1358619958-21209-6-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.14+249~gbbd600f (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-pc-linux-gnu)
Date: Sun, 20 Jan 2013 13:55:14 -0800
Message-ID: <87d2wzwmd9.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: David Bremner <bremner@debian.org>
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 19 2013, david@tethera.net wrote:
> This roughly mimics the samba4 argument. The presence of the command
> line argument overrides any value of NOTMUCH_TALLOC_REPORT in the
> environment.
> ---
>  man/man1/notmuch.1 |    8 ++++++++
>  notmuch.c          |   18 +++++++-----------
>  2 files changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1
> index 6bf9b2e..5c58c41 100644
> --- a/man/man1/notmuch.1
> +++ b/man/man1/notmuch.1
> @@ -70,6 +70,14 @@ Print a synopsis of available commands and exit.
>  Print the installed version of notmuch, and exit.
>  .RE
>=20=20
> +.RS 4
> +.TP 4
> +.BI \-\-leak-report=3D path
> +
> +Write a detailed report of all memory allocated via talloc to
> +.I path
> +.RE

Do we really need a command line option for this?  Why isn't the env var
sufficient?  This just seems to me like it clutters the interface, for
an option that is purely for debugging and should rarely if ever be used
by most users.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQ/GfCAAoJEO00zqvie6q8IGkP/1eBH3zm106ajGiyaHNfUvbK
1PHkdH3GIFr3FpChi3jO7oxVbAIK1pyWSBe1OxnUVCOaCmXRop59G6aeismA0de2
pvnXEU9MbRq5eloJWsJacEMjgSS3OS1VKBxwv72W2J72bfiaM1QyjP0tI9cUIyx7
DaxKAhzpigM+hUGo3WOwcn3f+A7PF5IWGXBraMtff8UrDCnUL3HoztvE6z/EeUtw
FvCkndujCO5Hwn75bwXNMxYo6pm3TMeqypWGqxHlUv6faZWq2SHHGAMXHwkezqbI
my0s1m/AOHwUrX71liSZN5tM9iJJRYypKLyu1kf9UOsoQDWQAvjCwIt7Bd3TXYMh
ZY4SrkiYgU37mIawVSz75zpbPqPG4jnDngfDfCIGWA3oeueoUN5hIYE3hh2zgcvL
b5g2Vyc4YmwSP6SIhUglLmS8uuLHy1l6wej6uigQT5oHh1/1ilFeSGWHZvdLZYMc
A06RhY5VGKi7zKbvoRwDg64Dp7P7tXmhMpXA8KN4TsSTjBL+nIUtqPL9EDLi8jZe
/es+4fDEizP9ok88JMAhSHvniskQEOn1tZ10T/a6CKk2TQEBF0kZ18SiDuRiiPrL
9k3AkRM1YY8gjGeI5DA94bqL4RrJzuEcjfUdQtxtGNX9HSg4xJOYQQwKJ22vudRi
Ggj1d0heKvV+g9uO06yU
=W7TF
-----END PGP SIGNATURE-----
--=-=-=--