1 Return-Path: <bart@jukie.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 224D5431FBC
\r
6 for <notmuch@notmuchmail.org>; Wed, 25 Nov 2009 12:56:41 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id vWrLuy3vU9aT for <notmuch@notmuchmail.org>;
\r
11 Wed, 25 Nov 2009 12:56:40 -0800 (PST)
\r
12 Received: from tau.jukie.net (tau.jukie.net [216.239.93.128])
\r
13 by olra.theworths.org (Postfix) with ESMTP id 710FA431FAE
\r
14 for <notmuch@notmuchmail.org>; Wed, 25 Nov 2009 12:56:40 -0800 (PST)
\r
15 Received: by tau.jukie.net (Postfix, from userid 1000)
\r
16 id D67B2C0090B; Wed, 25 Nov 2009 15:56:39 -0500 (EST)
\r
17 Date: Wed, 25 Nov 2009 15:56:39 -0500
\r
18 From: Bart Trojanowski <bart@jukie.net>
\r
19 To: Jan Janak <jan@ryngle.com>
\r
20 Message-ID: <20091125205639.GJ29312@jukie.net>
\r
21 References: <1259100630-13673-1-git-send-email-jan@ryngle.com>
\r
22 <1259100630-13673-2-git-send-email-jan@ryngle.com>
\r
23 <1259100630-13673-3-git-send-email-jan@ryngle.com>
\r
25 Content-Type: text/plain; charset=us-ascii
\r
26 Content-Disposition: inline
\r
27 In-Reply-To: <1259100630-13673-3-git-send-email-jan@ryngle.com>
\r
28 User-Agent: Mutt/1.5.18 (2008-05-17)
\r
29 Cc: notmuch@notmuchmail.org
\r
30 Subject: Re: [notmuch] [PATCH 2/4] notmuch: Config option to specify tags to
\r
31 be applied by 'notmuch new'.
\r
32 X-BeenThere: notmuch@notmuchmail.org
\r
33 X-Mailman-Version: 2.1.12
\r
35 List-Id: "Use and development of the notmuch mail system."
\r
36 <notmuch.notmuchmail.org>
\r
37 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
38 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
39 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
40 List-Post: <mailto:notmuch@notmuchmail.org>
\r
41 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
42 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
44 X-List-Received-Date: Wed, 25 Nov 2009 20:56:41 -0000
\r
48 I really want this feature to get in, so I am going to do my best to
\r
51 Here are some more sticking points...
\r
54 > +notmuch_config_get_new_tags (notmuch_config_t *config, size_t *length);
\r
56 If you are not giving over control of the pointer to the caller please
\r
57 return const char * const *.
\r
61 > + char **new_tags;
\r
63 ... this should probably be const char **.
\r
68 > +notmuch_config_get_new_tags (notmuch_config_t *config, size_t *length)
\r
72 > + unsigned int count, i;
\r
74 > + if ((tags = notmuch_config_get_new_tags (config, &count)) == NULL)
\r
77 size_t != unsigned int on all platforms. Please stick with one or the
\r
78 other. Note there are a few calls to fix here.
\r
83 WebSig: http://www.jukie.net/~bart/sig/
\r